pkg/ansible: Adding ansible operator runner package#472
Merged
shawn-hurley merged 1 commit intoSep 19, 2018
Merged
Conversation
shawn-hurley
force-pushed
the
feature/add-AO-runner
branch
2 times, most recently
from
52387f8 to
f0605d2
Compare
shawn-hurley
changed the title
hasbro17
reviewed
Sep 14, 2018
| } | ||
| return nil | ||
| } | ||
| func (r *runner) makeParameters(u *unstructured.Unstructured) map[string]interface{} { |
Contributor
There was a problem hiding this comment.
It might be helpful to have a comment here to explain what the output format for parameters is:
{ "meta": {
"name": "<cr-name>",
"namespace": "<cr-namespace>",
},
<CR.spec fields>,
"_<group>_<kind>": {
<Full CR contents>
},
}
At least that's what I think it ends up as in the input directory's env/extravars.
hasbro17
reviewed
Sep 14, 2018
|
|
||
| func (r *runner) isFinalizerRun(u *unstructured.Unstructured) bool { | ||
| finalizersSet := r.Finalizer != nil && u.GetFinalizers() != nil | ||
| // The the resource is deleted and our finalizer is present, we need to run the finalizer |
Contributor
|
LGTM after nits |
dymurray
reviewed
Sep 17, 2018
| if req.Method == http.MethodPost { | ||
| logrus.Info("injecting owner reference") | ||
| dump, _ := httputil.DumpRequest(req, false) | ||
| fmt.Println(string(dump)) |
Contributor
There was a problem hiding this comment.
Is this supposed to be here? Seems like this should be a debug statement
dymurray
reviewed
Sep 17, 2018
| owner := metav1.OwnerReference{} | ||
| json.Unmarshal(authString, &owner) | ||
|
|
||
| logrus.Printf("%#+v", owner) |
Contributor
There was a problem hiding this comment.
This also seems like a debug statement.
dymurray
reviewed
Sep 17, 2018
| http.Error(w, m, http.StatusInternalServerError) | ||
| return | ||
| } | ||
| logrus.Printf(string(newBody)) |
dymurray
approved these changes
Sep 17, 2018
Contributor
dymurray
left a comment
dymurray
left a comment
There was a problem hiding this comment.
Only had some small nits. Everything else looks sane to me.
shawn-hurley
force-pushed
the
feature/add-AO-runner
branch
2 times, most recently
from
ac18a89 to
249e4cb
Compare
fanminshi
reviewed
Sep 18, 2018
| } | ||
|
|
||
| func (e *EventReceiver) handleEvents(w http.ResponseWriter, r *http.Request) { | ||
|
|
Contributor
There was a problem hiding this comment.
no need to have extra line here.
| "code": "410", | ||
| }).Info("stopped and not accepting additional events for this job") | ||
| return | ||
| } else { |
Contributor
There was a problem hiding this comment.
is else statement here necessary? since the previous if condition returns.
| return err | ||
| } | ||
|
|
||
| if i.PlaybookPath != "" { |
Contributor
There was a problem hiding this comment.
if we change to
if i.PlaybookPath == "" {
return nil
}
...I think the code has less nested if statement which makes the code cleaner.
Member
Author
There was a problem hiding this comment.
It might be a little cleaner but
- the nested if's are for error checking not logic. I would suggest that this is not that big of a concern.
- I think it is more clear, do X if PlaybookPath is set, rather than, if PlaybookPath is unset return and always do X. The first is more accurate to what we want rather than the second.
Thoughts?
Contributor
There was a problem hiding this comment.
fair enough. let's keep as it is.
shawn-hurley
force-pushed
the
feature/add-AO-runner
branch
from
c4976f3 to
26d7d6d
Compare
Contributor
|
lgtm |
dymurray
approved these changes
Sep 18, 2018
shawn-hurley
force-pushed
the
feature/add-AO-runner
branch
from
26d7d6d to
57bc0fd
Compare
hasbro17
pushed a commit
to hasbro17/operator-sdk
that referenced
this pull request
Oct 3, 2018
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Oct 12, 2018
operator-framework#566) * pkg/ansible: Adding paramconv and kubeconfig to ansible operator. (operator-framework#471) * Adding runner package. (operator-framework#472) * pkg/ansible: Adding ansible operator controller and events package (operator-framework#473) * make ansible task log outputs more readable (operator-framework#545)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.