*: process actions returned by handler#57
Closed
hasbro17 wants to merge 1 commit intooperator-framework:masterfrom
hasbro17:haseeb/add-action
Closed
*: process actions returned by handler#57hasbro17 wants to merge 1 commit intooperator-framework:masterfrom hasbro17:haseeb/add-action
hasbro17 wants to merge 1 commit intooperator-framework:masterfrom
hasbro17:haseeb/add-action
Conversation
fanminshi
reviewed
Feb 24, 2018
| } | ||
|
|
||
| const ( | ||
| // Function names for supported functions |
Contributor
There was a problem hiding this comment.
have you consider using enum for function name?
Contributor
|
@hasbro17 |
| // For actions done before the failed action, there is no rollback. | ||
| type Handler interface { | ||
| Handle(sdkTypes.Context, sdkTypes.Event) []sdkTypes.Action | ||
| Handle(sdkTypes.Context, sdkTypes.Event) []sdkAction.Action |
Contributor
There was a problem hiding this comment.
'Action' should be in sdk/types.
Only the action implementations go into sdk/action.
| ) | ||
|
|
||
| // FuncName defines the name of the function of an Action. | ||
| type FuncName string |
Contributor
There was a problem hiding this comment.
Put FuncName to sdk/types too?
Contributor
Author
|
Going to split the PR into two for |
| } | ||
|
|
||
| // Update it if it already exists | ||
| // TODO: Should resourceVersion conflict be handled differently |
Contributor
There was a problem hiding this comment.
Maybe brainstorm about all the potential failure cases and list them in TODO?
Merged
Contributor
Author
|
Closing in favour of #58 |
m1kola
pushed a commit
to m1kola/operator-sdk
that referenced
this pull request
Jun 7, 2024
Fix install commands for ubi8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The informer's sync will now process the actions returned by
Handle().The two supported actions are: