sdk/action: implement kube delete#61
Merged
hasbro17 merged 1 commit intooperator-framework:masterfrom Feb 26, 2018
hasbro17:haseeb/add-kube-delete
Merged
sdk/action: implement kube delete#61hasbro17 merged 1 commit intooperator-framework:masterfrom hasbro17:haseeb/add-kube-delete
hasbro17 merged 1 commit intooperator-framework:masterfrom
hasbro17:haseeb/add-kube-delete
Conversation
fanminshi
reviewed
Feb 26, 2018
| } | ||
|
|
||
| // KubeDelete deletes an object | ||
| // KubeDelete deletes an object if it still exists |
Contributor
There was a problem hiding this comment.
if it still exists -> if exists?
seems more concise
Contributor
Author
There was a problem hiding this comment.
I agree but I'm pretty sure the latter statement is grammatically incorrect. So probably have to keep it as it is.
Contributor
There was a problem hiding this comment.
on a second thought, i think you are right.
| apiVersion, kind := gvk.ToAPIVersionAndKind() | ||
| objectInfo := objectInfoString(kind, name, namespace) | ||
|
|
||
| resourceClient, _, err := k8sclient.GetResourceClient(apiVersion, kind, namespace) |
Contributor
There was a problem hiding this comment.
just curious if GetResourceClient caches resource client based on type? if not , maybe we can cache client based on type in the future.
Contributor
Author
There was a problem hiding this comment.
Yes the dynamic ClientPool implementation already does that.
https://github.com/kubernetes/client-go/blob/master/dynamic/client_pool.go#L93-L104
Contributor
|
lgtm after a small suggestion and some question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part [2/2] of #57
/cc @hongchaodeng @fanminshi