wip: work on bumping KB by varshaprasad96 · Pull Request #6514 · operator-framework/operator-sdk

varshaprasad96 · 2023-07-25T19:00:11Z

Things to do:

Update ansible operator code based on ✨ add logging to Enqueue_owner event handler kubernetes-sigs/controller-runtime#2427
Generate testdata
Update documentation
Add changelog/migration guide

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
Add or update relevant sections of the docs website in website/content/en/docs

closes: #6571

varshaprasad96 · 2023-07-25T19:00:36Z

/hold
Please hold from reviewing. A bunch of changes need to be done, work in progress.

varshaprasad96 · 2023-07-27T21:29:51Z

Blocked by kubernetes-sigs/controller-runtime#2427

Bumping versions of dependencies for k8s 1.27 Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

This commit fixes most of the OLM client and helm controller code to accomodate the changes made in controller-runtime. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

This commit fixes some of the dependency versions which need to be pinned specifically in the project to be able to run successfully. It also fixes the handler code base in ansible. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

This commit is the first iteration towards fixing breaking changes in ansible to bump k8s dependencies. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

Neo2308 · 2023-09-02T12:07:37Z

@varshaprasad96 raised a PR to this branch with the fix for scorecard. (Tested for go e2e)

…n-error Fix scorecard test failures

varshaprasad96 · 2023-09-06T21:10:02Z

@Neo2308 I have merged your pull request.

To fix the sanity: Can you bump the local operator-sdk version which you have to the latest (1.31) and run make generate. That should fix the diffs.

To fix unit tests: The new handler package in ansible is using envtest binaries. The KUBEBUILDER_ASSETS var should be set to point to the right location where binaries are downloaded using setup-envtest. Similar to how it is done here:

operator-sdk/Makefile

Line 169 in e67da35

    
           KUBEBUILDER_ASSETS = $(PWD)/$(shell go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest && $(shell go env GOPATH)/bin/setup-envtest use $(K8S_VERSION) --bin-dir tools/bin/ -p path)

. Either we can set this up before calling the unit test target, or remove the handler tests package from in here and have it tested separately.

Thanks for working on this! Feel free to lmk if you have any questions.

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

Neo2308 · 2023-09-07T09:38:23Z

@varshaprasad96 raised a PR to this branch with the fix for unit & sanity tests.

Need help on fixing the e2e tests.

Fixing sanity and unit tests

varshaprasad96 · 2023-09-11T15:11:27Z

@Neo2308 Thanks for the fix. Looking into the CI, it seems like the e2e tests are failing on the run packagemanifests tests for OLM. Before we start looking into it and figure out the issue, I'm wondering if it is even required. Packagemanifests have been deprecated for long, are not being used widely, since folks have moved to using operator bundles. So it should be fine to remove them. I've created a slack thread to confirm with other maintainers: https://kubernetes.slack.com/archives/C017UU45SHL/p1694445066414709

openshift-merge-robot · 2023-09-13T08:50:25Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Neo2308 · 2023-09-22T19:49:07Z

@varshaprasad96 did we hear back on the slack thread? I dont have access to this slack organisation.

varshaprasad96 · 2023-09-22T20:30:51Z

@Neo2308 I have not received any reply on this. But to unblock for now, I'd say to proceed with removing tests for package manifests but ensure that run bundle works as expected. Those can be added back in, if there is any strong opinion against removing them during reviews.

Neo2308 · 2023-09-23T19:50:21Z

@varshaprasad96 could you take this up since I am not sure what exactly needs to be removed?

everettraven · 2023-09-25T18:14:12Z

/assign @oceanc80

Signed-off-by: Adam D. Cornett <adc@redhat.com>

removing packagemanifest tests

Neo2308 · 2023-12-11T07:25:44Z

@varshaprasad96 / @oceanc80 What are the next steps here? Is there something I can help with?
Considering that k8s 1.29 is scheduled to be released this week, we would be 3 versions behind the master.

Neo2308 · 2023-12-30T09:51:31Z

@varshaprasad96 could we close this PR since its been covered in #6613 and available in https://github.com/operator-framework/operator-sdk/releases/tag/v1.33.0

openshift-bot · 2024-03-30T01:01:00Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2024-04-29T08:30:18Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2024-05-30T00:01:11Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2024-05-30T00:01:15Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023

varshaprasad96 had a problem deploying to deploy July 25, 2023 19:00 — with GitHub Actions Failure

varshaprasad96 had a problem deploying to deploy July 25, 2023 19:00 — with GitHub Actions Error

varshaprasad96 had a problem deploying to deploy July 25, 2023 19:00 — with GitHub Actions Failure

varshaprasad96 had a problem deploying to deploy July 25, 2023 19:00 — with GitHub Actions Error

varshaprasad96 temporarily deployed to deploy July 25, 2023 19:00 — with GitHub Actions Inactive

varshaprasad96 temporarily deployed to deploy July 27, 2023 21:27 — with GitHub Actions Inactive

varshaprasad96 had a problem deploying to deploy July 27, 2023 21:27 — with GitHub Actions Failure

varshaprasad96 had a problem deploying to deploy July 27, 2023 21:27 — with GitHub Actions Error

varshaprasad96 had a problem deploying to deploy July 27, 2023 21:27 — with GitHub Actions Failure

varshaprasad96 had a problem deploying to deploy July 27, 2023 21:27 — with GitHub Actions Error

varshaprasad96 mentioned this pull request Jul 27, 2023

Update controller-runtime from 0.14 to 0.15 #6465

Closed

varshaprasad96 force-pushed the bump/k8s-1.27 branch from 3dee9ee to c1d55d7 Compare August 14, 2023 14:41

varshaprasad96 had a problem deploying to deploy August 14, 2023 14:41 — with GitHub Actions Error

varshaprasad96 temporarily deployed to deploy August 14, 2023 14:41 — with GitHub Actions Inactive

varshaprasad96 had a problem deploying to deploy August 14, 2023 14:41 — with GitHub Actions Error

varshaprasad96 had a problem deploying to deploy August 14, 2023 14:41 — with GitHub Actions Failure

Neo2308 reviewed Aug 14, 2023

View reviewed changes

Comment thread go.mod Outdated

Neo2308 reviewed Aug 14, 2023

View reviewed changes

Comment thread go.mod Outdated

varshaprasad96 added 4 commits August 17, 2023 17:06

[Fix] Bumping versions of KB, C_R and other deps

4a13e17

Bumping versions of dependencies for k8s 1.27 Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

[fix] Fix olm and helm source code to use latest changes

8c14bf6

This commit fixes most of the OLM client and helm controller code to accomodate the changes made in controller-runtime. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

[fix] Fix breaking ansible changes

e42db41

This commit is the first iteration towards fixing breaking changes in ansible to bump k8s dependencies. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

Neo2308 mentioned this pull request Sep 2, 2023

Fix scorecard test failures varshaprasad96/operator-sdk#203

Merged

Merge pull request #203 from Neo2308/feature/fix-scorecard-deprecatio…

ab1ef41

…n-error Fix scorecard test failures

varshaprasad96 temporarily deployed to deploy September 6, 2023 21:06 — with GitHub Actions Inactive

Neo2308 added 3 commits September 7, 2023 11:02

Fix sanity test failure

99d136b

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

Fix unit test failure

8d4c16f

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

Fixing flaky test

44e7380

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

Neo2308 mentioned this pull request Sep 7, 2023

Fixing sanity and unit tests varshaprasad96/operator-sdk#204

Merged

Merge pull request #204 from Neo2308/feature/fix-unit-tests

b38b849

Fixing sanity and unit tests

josvazg mentioned this pull request Sep 27, 2023

Bump sigs.k8s.io/controller-runtime from 0.14.6 to 0.16.2 mongodb/mongodb-atlas-kubernetes#1142

Closed

This was referenced Oct 2, 2023

suport kubebuilder go/v4 #6577

Closed

helm-operator: reduce cache memory footprint #6377

Merged

acornett21 and others added 2 commits October 9, 2023 11:40

removing packagemanifest tests

172b7e6

Signed-off-by: Adam D. Cornett <adc@redhat.com>

Merge pull request #205 from acornett21/bump/k8s-1.27

d573720

removing packagemanifest tests

oceanc80 mentioned this pull request Oct 18, 2023

Bump golang, k8s operator-framework/ansible-operator-plugins#37

Merged

Conversation

varshaprasad96 commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varshaprasad96 commented Jul 25, 2023

Uh oh!

varshaprasad96 commented Jul 27, 2023

Uh oh!

Uh oh!

Uh oh!

Neo2308 commented Sep 2, 2023

Uh oh!

varshaprasad96 commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neo2308 commented Sep 7, 2023

Uh oh!

varshaprasad96 commented Sep 11, 2023

Uh oh!

openshift-merge-robot commented Sep 13, 2023

Uh oh!

Neo2308 commented Sep 22, 2023

Uh oh!

varshaprasad96 commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neo2308 commented Sep 23, 2023

Uh oh!

everettraven commented Sep 25, 2023

Uh oh!

Neo2308 commented Dec 11, 2023

Uh oh!

Neo2308 commented Dec 30, 2023

Uh oh!

openshift-bot commented Mar 30, 2024

Uh oh!

openshift-bot commented Apr 29, 2024

Uh oh!

openshift-bot commented May 30, 2024

Uh oh!

openshift-ci Bot commented May 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

varshaprasad96 commented Jul 25, 2023 •

edited

Loading

varshaprasad96 commented Sep 6, 2023 •

edited

Loading

varshaprasad96 commented Sep 22, 2023 •

edited

Loading