Skip to content

commands/operator-sdk: pull deps after code generation#81

Merged
fanminshi merged 2 commits intooperator-framework:masterfrom
fanminshi:pull_deps
Mar 1, 2018
Merged

commands/operator-sdk: pull deps after code generation#81
fanminshi merged 2 commits intooperator-framework:masterfrom
fanminshi:pull_deps

Conversation

@fanminshi
Copy link
Copy Markdown
Contributor

@fanminshi fanminshi commented Mar 1, 2018

this pr allows operator-sdk new command to create vendor/ after code/scripts generation. this ensure the default generated files can be compiled.

@fanminshi
Copy link
Copy Markdown
Contributor Author

fanminshi commented Mar 1, 2018

Manual Test:

$ operator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=AppService
$ cd app-operator
$ ls
Gopkg.lock	cmd		deploy		tmp
Gopkg.toml	config		pkg		vendor

@fanminshi
Copy link
Copy Markdown
Contributor Author

fanminshi commented Mar 1, 2018

cc/ @hasbro17

@hasbro17
Copy link
Copy Markdown
Contributor

hasbro17 commented Mar 1, 2018

LGTM

@fanminshi fanminshi merged commit e0c327e into operator-framework:master Mar 1, 2018
@fanminshi fanminshi mentioned this pull request Mar 1, 2018
Closed
21 tasks
m1kola pushed a commit to m1kola/operator-sdk that referenced this pull request Jun 7, 2024
@jmrodri
Updating o-e-(ansible|helm|sdk) builder & base images to be consisten…
11b33ae 
…t with ART

Combining PRs operator-framework#76, operator-framework#77, operator-framework#80, operator-framework#81, operator-framework#83 since they are based on really old
branches with failing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanminshi @hasbro17