This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Externalize storage package#665
Merged
ncdc merged 1 commit intooperator-framework:mainfrom Aug 1, 2023
Merged
Conversation
everettraven
approved these changes
Jul 31, 2023
Contributor
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
I think this is a good starting point and we can iteratively make improvements to the package as it begins being used by catalogd. That being said, I can see a case for only externalizing the interfaces in storage.go since everything else is pretty tailored around Rukpak and the notion of using Bundles for things. IMO this isn't a big deal as we can iterate on this to make it more generic as the need arises.
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
=======================================
Coverage 31.94% 31.94%
=======================================
Files 10 10
Lines 479 479
=======================================
Hits 153 153
Misses 304 304
Partials 22 22
|
ncdc
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Externalize storage package for use by catalogd.
Closes #656