Conversation
…r-cannot-save-their-notifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no
…r-cannot-save-their-notifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no
Fixes rspec ./modules/costs/spec/features/time_entry_dialog_spec.rb:330 The reason it failed is that the id of the searched for work package might also be the id of the project or the status. Using the subject is stable
…in-wp-unit-costs-1 [72685] User can input anything in WP unit costs
…sponsive-on-mobile-after-pir [70388] Sidebar menu button unresponsive on mobile (after PIR)
…ting-is-unclear [#73196 & friends] Meeting participants sorting is unclear
…their-notifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no
…otifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no Bug/73464 user cannot save their notifications preferences if they save the show versions folded boolean as no
# Conflicts: # modules/backlogs/app/views/rb_master_backlogs/_backlog_and_sprints_list.html.erb
… does not respect project boundaries https://community.openproject.org/work_packages/73446 - Remove default order from work_packages association and create order_by_position scope for work packages - Add sprint planning spec - Make sure the work packages without a position are placed at the end of the list. - Add specs for WorkPackage.order_by_position
…-their-story-points-in-sprint-header-does-not-respect-project-boundaries [#73446] Sum of work packages and their story points in sprint header are incorrect
# Conflicts: # config/locales/crowdin/el.yml # modules/backlogs/app/forms/my/backlogs_form.rb # modules/backlogs/app/views/shared/_view_my_settings.html.erb # modules/backlogs/config/locales/crowdin/ru.yml # modules/backlogs/config/locales/crowdin/uk.yml # modules/two_factor_authentication/config/locales/crowdin/el.yml # modules/wikis/config/locales/crowdin/uk.yml
| @@ -39,9 +39,6 @@ uk: | |||
| sprint_sharing: "Sprint sharing" | |||
| sprint: | |||
| duration: "Тривалість спринту" | |||
There was a problem hiding this comment.
This goes for a few of these translation files, just taking this one as an example:
The red changes contain the correct keys. Of course we don't have a localized version for these yet, as not only the keys, but also the wording within the values has been changed.
But: since these are all based upon the master en.yml file, we should be able to just ignore these 🤔 They will be overwritten by the next Crowdin import IIRC.
There was a problem hiding this comment.
@EinLama the translations were handled automatically using the script in #22249 - the idea of that PR was to reduce churn, but it might just be better to always prefer dev. See comment here. Feedback welcome. / @toy
EinLama
left a comment
There was a problem hiding this comment.
I resolved the conflicts that bothered me, LGTM now! 👍🏻
|
The failing spec is green locally and seems to be flaky |
Created by GitHub action
Replaces #22681