ci: include Cargo.toml in publish version bump commit#315
Conversation
The publish workflow runs sync-native-versions.js which updates crates/codegraph-core/Cargo.toml with the new version, but the version bump commit only staged package.json, package-lock.json, CHANGELOG.md, and DEPENDENCIES.json — leaving Cargo.toml out. This caused the native engine version to drift from the npm version, requiring manual fixes like #310. Add Cargo.toml to both the git diff check and git add in the "Push version bump via PR" step.
|
Claude finished @carlos-alm's task —— View job PR Review: Include Cargo.toml in Version Bump CommitTodo List:
Root Cause AnalysisProblem Being Solved: The publish workflow runs Why This Approach: This is a legitimate fix addressing a real synchronization issue. The Risk Assessment: ✅ LOW RISK - This is a proper fix, not symptom hiding. Configuration Change DetectionThe workflow file modification adds
This is a legitimate workflow improvement that ensures all version-synchronized files are committed together. No concerning rule relaxations or threshold lowering detected. Test Integrity Assessment✅ No test modifications - This PR only touches workflow configuration Code Quality ReviewStrengths:
Analysis:
No issues found - This is a clean, targeted fix. Final AssessmentMinor suggestion for future robustness: Consider adding a CI check that verifies |
Greptile SummaryFixed CI/CD bug where
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 76b12d9 |
Summary
sync-native-versions.jswhich updatescrates/codegraph-core/Cargo.tomlwith the release version, but the version bump commit only stagedpackage.json,package-lock.json,CHANGELOG.md, andDEPENDENCIES.jsonCargo.tomlout of the commit, causing the native engine version to drift from the npm version after each release2.6.0to3.0.0Adds
crates/codegraph-core/Cargo.tomlto both thegit diffcheck andgit addin the "Push version bump via PR" step.Test plan
Cargo.tomlchangescodegraph inforeports matching native/npm versions after release