Skip to content

fix: Rename remove_all_forced_decision #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msohailhussain merged 2 commits into from
Dec 8, 2021
Merged

fix: Rename remove_all_forced_decision #291

msohailhussain merged 2 commits into from
Dec 8, 2021

Conversation

@ozayr-zaviar
Copy link
Contributor

@ozayr-zaviar ozayr-zaviar commented Dec 6, 2021 •
edited
Loading

Summary

  • remove_all_forced_decision renamed to remove_all_forced_decisions to sync with other SDKs.

Test plan

@coveralls
Copy link

coveralls commented Dec 6, 2021 •
edited
Loading

Coverage Status

Coverage increased (+6.0e-05%) to 99.569% when pulling a1be17b on uzair/fd-rename into daf4ee1 on master.

@ozayr-zaviar ozayr-zaviar reopened this Dec 7, 2021
@msohailhussain msohailhussain requested a review from jaeopt December 8, 2021 19:24
@msohailhussain msohailhussain marked this pull request as ready for review December 8, 2021 19:24
@msohailhussain msohailhussain requested a review from a team as a code owner December 8, 2021 19:24
jaeopt
jaeopt approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain merged commit ac29ac1 into master Dec 8, 2021
@msohailhussain msohailhussain deleted the uzair/fd-rename branch December 8, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@ozayr-zaviar ozayr-zaviar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ozayr-zaviar @coveralls @jaeopt @msohailhussain