Skip to content

fix: Rename remove_all_forced_decision #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msohailhussain merged 2 commits into from
Dec 8, 2021
Merged

fix: Rename remove_all_forced_decision #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a10e38a
rename remove_all_forced_decision
ozayr-zaviar Dec 6, 2021
a1be17b
Merge branch 'master' into uzair/fd-rename
ozayr-zaviar Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/optimizely/optimizely_user_context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ def remove_forced_decision(context)
#
# @return - true if forced decisions have been removed successfully.

def remove_all_forced_decision
def remove_all_forced_decisions
return false if @optimizely_client&.get_optimizely_config.nil?

@forced_decision_mutex.synchronize { @forced_decisions.clear }
true
end
Expand Down
10 changes: 5 additions & 5 deletions spec/optimizely_user_context_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
expect(status).to eq(decision)
status = user_context_obj.remove_forced_decision(context)
expect(status).to be true
status = user_context_obj.remove_all_forced_decision
status = user_context_obj.remove_all_forced_decisions
expect(status).to be true
end

Expand Down Expand Up @@ -547,7 +547,7 @@
expect(user_context_obj.get_forced_decision(context_with_flag)).to eq(decision_for_flag)
expect(user_context_obj.get_forced_decision(context_with_rule)).to eq(decision_for_rule)

user_context_obj.remove_all_forced_decision
user_context_obj.remove_all_forced_decisions
expect(user_context_obj.get_forced_decision(context_with_flag)).to be_nil
expect(user_context_obj.get_forced_decision(context_with_rule)).to be_nil

Expand Down Expand Up @@ -629,7 +629,7 @@
allow(user_context_obj).to receive(:set_forced_decision)
allow(user_context_obj).to receive(:get_forced_decision)
allow(user_context_obj).to receive(:remove_forced_decision)
allow(user_context_obj).to receive(:remove_all_forced_decision)
allow(user_context_obj).to receive(:remove_all_forced_decisions)

context_with_flag_1 = Optimizely::OptimizelyUserContext::OptimizelyDecisionContext.new('0', nil)
decision_for_flag_1 = Optimizely::OptimizelyUserContext::OptimizelyForcedDecision.new('var')
Expand Down Expand Up @@ -685,7 +685,7 @@

# remove all forced decision
threads << Thread.new do
user_context_obj.remove_all_forced_decision
user_context_obj.remove_all_forced_decisions
end

threads.each(&:join)
Expand All @@ -696,7 +696,7 @@
expect(user_context_obj).to have_received(:get_forced_decision).with(context_with_flag_2).exactly(100).times
expect(user_context_obj).to have_received(:remove_forced_decision).with(context_with_flag_1).exactly(100).times
expect(user_context_obj).to have_received(:remove_forced_decision).with(context_with_flag_2).exactly(100).times
expect(user_context_obj).to have_received(:remove_all_forced_decision).once
expect(user_context_obj).to have_received(:remove_all_forced_decisions).once
end
end
end