Fixes #36. Add condition to decreaseIndentPattern regex to support self closing-tags

[jeffshaver]

If there is any more info you need, please let me know.

I assume that i will need to add some tests maybe, but I didn't see the correct place to put them. Guidance there?

[orktes]

Hi!

Thanks for contributing!

Indentation test file is located in
https://github.com/orktes/atom-react/blob/master/spec/fixtures/sample.jsx
and the expected result in
https://github.com/orktes/atom-react/blob/master/spec/fixtures/sample-formatted.jsx

So adding something like

// sample.jsx
<div>
<span 
foo="bar"
bar="foo"
/>
<span barfoo="123" />
<span>
foo
</span>
</div>

// sample-formatted.jsx
<div>
  <span 
    foo="bar"
    bar="foo"
  />
  <span barfoo="123" />
  <span 
    foo="bar"
    bar="foo" />
  <span>
    foo
  </span>
</div>

ps. currently it seems that one tokenizer test is failing against the latest lang-javascript package that atom-react is extending with JSX. Feel free to ignore that for now.

[orktes]

ps ignore appveyor (I should remove that as it causes more trouble than it helps)

[jeffshaver]

@orktes thanks for the quick response!

Will work this later today (hopefully). Just to be clear in regards to #131, this isn't really reading the eslint config. I guess it may be possible to do that, but I didn't think it was necessary. This seems more like a bug than preference (to me, but I don't know if everyone writes jsx like me).

This is basically what I end up with when I use self-closing tags right now:

<MyComponent
  id="a"
  {...this.props}
  /> // Note how this is indented

All this pr does is this:

<MyComponent
  id="a"
  {...this.props}
/> // This line gets auto-unindented now

[orktes]

Yeap. My own preference has been to close after last attribute but
reasoning for putting it onto a separate line is clear.

I added a separate issue about the eslint conf stuff.

On Monday, 4 January 2016, Jeffrey E. Shaver II notifications@github.com
wrote:

@orktes https://github.com/orktes thanks for the quick response!

Will work this later today (hopefully). Just to be clear in regards to
#131 #131, this isn't really
reading the eslint config. I guess it may be possible to do that, but I
didn't think it was necessary. This seems more like a bug than preference
(to me, but I don't know if everyone writes jsx like me).

This is basically what I end up with when I use self-closing tags right
now:

<MyComponent
id="a"
{...this.props}
/> // Note how this is indented

All this pr does is this:

<MyComponent
id="a"
{...this.props}
/> // This line gets auto-unindented now

—
Reply to this email directly or view it on GitHub
#131 (comment).

Ystävällisin terveisin,
Jaakko Lukkari

[jeffshaver]

@orktes I changed sample.jsx and sample-formatted.jsx and ran apm test. Only the one failed as you mentioned above.

[jeffshaver]

@orktes is there something else I need to do here?

[jeffshaver]

@orktes anything else on this?

[orktes]

Hi sorry for the delay. Been terribly busy with work. All good!

[orktes]

caused regression had to revert so we can release more urgent 1.4 related fixes.