Add check for "react-native" to the file type regex #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for `require('react-native')` in addition to `require('react')`. Tested the regex to make sure it matches both.
orktes
added a commit
that referenced
this pull request
Feb 15, 2015
Add check for "react-native" to the file type regex
Owner
|
Thanks! |
jeffshaver
added a commit
to jeffshaver/atom-react
that referenced
this pull request
Jan 4, 2016
…ort self-closing tags
jeffshaver
added a commit
to jeffshaver/atom-react
that referenced
this pull request
Jan 4, 2016
…ort self-closing tags
jeffshaver
added a commit
to jeffshaver/atom-react
that referenced
this pull request
Jan 5, 2016
…ort self-closing tags
orktes
added a commit
that referenced
this pull request
Jan 13, 2016
Fixes #36. Add condition to decreaseIndentPattern regex to support self closing-tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for
require('react-native')in addition torequire('react'). Tested the regex to make sure it matches both.Test case included.