-
Notifications
You must be signed in to change notification settings - Fork 11
Description
Summary of request
The kf profile introduced a small list of alternate classes that are only used for the KF Client/Server. Score will no longer directly support kf so this profile is being removed. Consequently, we want to remove all the alternate classes that are only used with the kf profile.
This will additionally let us remove all references to the kf profile throughout the code base.
Details
- manifest/kf
- storage/kf
- metadata/kf/KFMetadataService
- Remove
metadata/kfdirectory - Remove
"!kf"Profile annotation fromLegacyMetadataServiceLines 31 to 32 in f931ebe
@Profile("!kf") public class LegacyMetadataService implements MetadataService {
- Remove
- Remove
"!kf"from CLI Commands- MountCommand
score/score-client/src/main/java/bio/overture/score/client/command/MountCommand.java
Lines 70 to 71 in f931ebe
@Profile("!kf") public class MountCommand extends RepositoryAccessCommand { - UploadCommand
score/score-client/src/main/java/bio/overture/score/client/command/UploadCommand.java
Lines 47 to 48 in f931ebe
@Profile("!kf") public class UploadCommand extends RepositoryAccessCommand { - ViewCommand
score/score-client/src/main/java/bio/overture/score/client/command/ViewCommand.java
Lines 68 to 69 in f931ebe
@Profile("!kf") public class ViewCommand extends RepositoryAccessCommand {
- MountCommand
- Remove all
kfconfig from the application.yml-
kfandkfportalproperties in common profile:score/score-client/src/main/resources/application.yml
Lines 39 to 48 in f931ebe
kfportal: url: https://arranger.kids-first.io/june_13/graphql kf: token: url: https://v2i1r42t6d.execute-api.us-east-1.amazonaws.com/beta/token download: url: https://data.kidsfirstdrc.org partSize: 1073741824 expiration: 86400 -
kfactive profile configscore/score-client/src/main/resources/application.yml
Lines 85 to 103 in f931ebe
############################################################################### # Profile - "kf" ############################################################################### spring: config: activate: on-profile: kf # Storage server storage: url: https://kf.com client: ssl: custom: false ---
-
- Remove all
kfconfig from the test application.yml- Same code blocks as in the main application.yml
Additional Context
All references to this profile live in the Score Client. I believe this is a consequence of integrating the Score CLI with a custom backend (not Score Server) during the KF project. These projects are therefore disconnected and this integration can't be maintained within the main Score repo. If the current state needs to be persisted, it should be forked from Score version 5.11.0