Skip to content

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jul 1, 2016

Fixes hash in filename issue from #11692
Fixes #21301

@PVince81
Copy link
Contributor Author

PVince81 commented Jul 4, 2016

Ouch, looks like this messes up code integrity check signatures: https://ci.owncloud.org/job/core-ci-linux/database=sqlite,label=SLAVE/32200/testReport/junit/%28root%29/Test_IntegrityCheck_CheckerTest/testWriteCoreSignature/

1) Test\IntegrityCheck\CheckerTest::testWriteAppSignature
12:03:00 Expectation failed for method name is equal to <string:file_put_contents> when invoked 1 time(s)
12:03:00 Parameter 1 for invocation OC\IntegrityCheck\Helpers\FileAccessHelper::file_put_contents('/ssd/jenkins/workspace/core-c...e.json', '{\n    "hashes": {\n        "An...---"\n}') does not match expected value.
12:03:00 Failed asserting that two strings are equal.
12:03:00 --- Expected
12:03:00 +++ Actual
12:03:00 @@ @@
12:03:00  '{
12:03:00      "hashes": {
12:03:00          "AnotherFile.txt": "1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112",
12:03:00          "subfolder\/file.txt": "410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b"
12:03:00      },
12:03:00 -    "signature": "Y5yvXvcGHVPuRRatKVDUONWq1FpLXugZd6Km\/+aEHsQj7coVl9FeMj9OsWamBf7yRIw3dtNLguTLlAA9QAv\/b0uHN3JnbNZN+dwFOve4NMtqXfSDlWftqKN00VS+RJXpG1S2IIx9Poyp2NoghL\/5AuTv4GHiNb7zU\/DT\/kt71pUGPgPR6IIFaE+zHOD96vjYkrH+GfWZzKR0FCdLib9yyNvk+EGrcjKM6qjs2GKfS\/XFjj\/\/neDnh\/0kcPuKE3ZbofnI4TIDTv0CGqvOp7PtqVNc3Vy\/UKa7uF1PT0MAUKMww6EiMUSFZdUVP4WWF0Y72W53Qdtf1hrAZa2kfKyoK5kd7sQmCSKUPSU8978AUVZlBtTRlyT803IKwMV0iHMkw+xYB1sN2FlHup\/DESADqxhdgYuK35bCPvgkb4SBe4B8Voz\/izTvcP7VT5UvkYdAO+05\/jzdaHEmzmsD92CFfvX0q8O\/Y\/29ubftUJsqcHeMDKgcR4eZOE8+\/QVc\/89QO6WnKNuNuV+5bybO6g6PAdC9ZPsCvnihS61O2mwRXHLR3jv2UleFWm+lZEquPKtkhi6SLtDiijA4GV6dmS+dzujSLb7hGeD5o1plZcZ94uhWljl+QIp82+zU\/lYB1Zfr4Mb4e+V7r2gv7Fbv7y6YtjE2GIQwRhC5jq56bD0ZB+I=",
12:03:00 +    "signature": "FwhlmdN9n4i8SP8RfXIeCJkYPLQJc6l1zgDqkzHgnPadToDqtXyi5WhfGS5dbmutbYNQ+zzyxJ65X+hjqMlAkD1aNkE6wZ4jEf\/n0Rq0a4bxVVJsL\/m76JaqFqbte8MrMwnSvGJyAiehwa8gdDLloynlvF2\/SYJYhUmIRozRgQ5jTwIzHLqd8B56xjWxuzm0kFBuqVlYmR7abcES8qAaLNDNFq\/ve3pGvQeYL1gmojo3MTDvdtzHViK3s+nH92\/yzdL9H2dEk\/u2v6AHKLQ0ebKla3e5Xq2CvqHM\/gflfiivmotb6VGL7IMCFYQdjYk3qiSXCZXwdYkEF1LExFrRkCanaLP2qu8dK8Eh23MYm47uPj0ii\/qx3L9tX7lgpImU+dS9fDpWBNZEDqmzcx6ns5gdqX+\/UsxywOCpLTScfLi0p0RsFzxx52t4pZVbfATJ3n6QWDDdBveYs4LoBVaiAmjKK+yu9z10VwruhyZFz4B+CUVQyBBIpBz6a3aHLzsfYjLk7QVwu\/ecuVAzN9rvNwGhiJGKNPmAH0Ze9gGbSDsH25I2PqT+eZtegKfgjcOdcS9IEYcjkt+p5AQg9DEhbNmgchCcze3f5MZ8Se7Kg7wQtCQNA29EINuQzZd7xzzko+5dQPRPQbJuZn7sstOBqp\/bbT\/M3a1PAo3iUQGQe2A=",
12:03:00      "certificate": "-----BEGIN CERTIFICATE-----\r\nMIIEwTCCAqmgAwIBAgIUWv0iujufs5lUr0svCf\/qTQvoyKAwDQYJKoZIhvcNAQEF\r\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTEw\r\nMzIyNDk1M1oXDTE2MTEwMzIyNDk1M1owEjEQMA4GA1UEAwwHU29tZUFwcDCCAiIw\r\nDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAK8q0x62agGSRBqeWsaeEwFfepMk\r\nF8cAobMMi50qHCv9IrOn\/ZH9l52xBrbIkErVmRjmly0d4JhD8Ymhidsh9ONKYl\/j\r\n+ishsZDM8eNNdp3Ew+fEYVvY1W7mR1qU24NWj0bzVsClI7hvPVIuw7AjfBDq1C5+\r\nA+ZSLSXYvOK2cEWjdxQfuNZwEZSjmA63DUllBIrm35IaTvfuyhU6BW9yHZxmb8+M\r\nw0xDv30D5UkE\/2N7Pa\/HQJLxCR+3zKibRK3nUyRDLSXxMkU9PnFNaPNX59VPgyj4\r\nGB1CFSToldJVPF4pzh7p36uGXZVxs8m3LFD4Ol8mhi7jkxDZjqFN46gzR0r23Py6\r\ndol9vfawGIoUwp9LvL0S7MvdRY0oazLXwClLP4OQ17zpSMAiCj7fgNT661JamPGj\r\nt5O7Zn2wA7I4ddDS\/HDTWCu98Zwc9fHIpsJPgCZ9awoqxi4Mnf7Pk9g5nnXhszGC\r\ncxxIASQKM+GhdzoRxKknax2RzUCwCzcPRtCj8AQT\/x\/mqN3PfRmlnFBNACUw9bpZ\r\nSOoNq2pCF9igftDWpSIXQ38pVpKLWowjjg3DVRmVKBgivHnUnVLyzYBahHPj0vaz\r\ntFtUFRaqXDnt+4qyUGyrT5h5pjZaTcHIcSB4PiarYwdVvgslgwnQzOUcGAzRWBD4\r\n6jV2brP5vFY3g6iPAgMBAAEwDQYJKoZIhvcNAQEFBQADggIBACTY3CCHC+Z28gCf\r\nFWGKQ3wAKs+k4+0yoti0qm2EKX7rSGQ0PHSas6uW79WstC4Rj+DYkDtIhGMSg8FS\r\nHVGZHGBCc0HwdX+BOAt3zi4p7Sf3oQef70\/4imPoKxbAVCpd\/cveVcFyDC19j1yB\r\nBapwu87oh+muoeaZxOlqQI4UxjBlR\/uRSMhOn2UGauIr3dWJgAF4pGt7TtIzt+1v\r\n0uA6FtN1Y4R5O8AaJPh1bIG0CVvFBE58esGzjEYLhOydgKFnEP94kVPgJD5ds9C3\r\npPhEpo1dRpiXaF7WGIV1X6DI\/ipWvfrF7CEy6I\/kP1InY\/vMDjQjeDnJ\/VrXIWXO\r\nyZvHXVaN\/m+1RlETsH7YO\/QmxRue9ZHN3gvvWtmpCeA95sfpepOk7UcHxHZYyQbF\r\n49\/au8j+5tsr4A83xzsT1JbcKRxkAaQ7WDJpOnE5O1+H0fB+BaLakTg6XX9d4Fo7\r\n7Gin7hVWX7pL+JIyxMzME3LhfI61+CRcqZQIrpyaafUziPQbWIPfEs7h8tCOWyvW\r\nUO8ZLervYCB3j44ivkrxPlcBklDCqqKKBzDP9dYOtS\/P4RB1NkHA9+NTvmBpTonS\r\nSFXdg9fFMD7VfjDE3Vnk+8DWkVH5wBYowTAD7w9Wuzr7DumiAULexnP\/Y7xwxLv7\r\n4B+pXTAcRK0zECDEaX3npS8xWzrB\r\n-----END CERTIFICATE-----"
12:03:00  }'

@DeepDiver1975
Copy link
Member

Ouch, looks like this messes up code integrity check signatures: https://ci.owncloud.org/job/core-ci-linux/database=sqlite,label=SLAVE/32200/testReport/junit/%28root%29/Test_IntegrityCheck_CheckerTest/testWriteCoreSignature/

afaik there is an issue in the phpseclib which did not allow us to update in the past already

@LukasReschke knows more

@DeepDiver1975
Copy link
Member

@PVince81 let's update dependencies once we have #25513 merged

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syncing via SFTP External Storage fails for files with hash character

3 participants