Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 30, 2016

Description

Update some dependencies

Related Issue

#20787

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Aug 30, 2016
@SergioBertolinSG
Copy link
Contributor

Should

"phpseclib/phpseclib": "2.0.0",
be "phpseclib/phpseclib": "2.0.2" ? like said in #25339

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

@SergioBertolinSG no, because it breaks our signing... Until we have a solution for this we can't update it...

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

@DeepDiver1975 I took the liberty to also add the davclient.js version to 0.0.1 since we now tagged it. Looks better than a commit id.

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

@DeepDiver1975 looks like the update makes some tests unhappy:

Test\Command\AsyncBusTest::testClosureSelf
Error: Cannot access self:: when no class scope is active

all these:

    Test\Command\AsyncBusTest.testClosureSelf
    Test\Command\AsyncBusTest.testClosureBind
    Tests\Core\Command\Config\App\GetConfigTest::testGet.testGet with data set #2
    Tests\Core\Command\Config\System\GetConfigTest::testGet.testGet with data set #2
    Tests\Core\Command\Config\System\GetConfigTest::testGet.testGet with data set #22
    Tests\Core\Command\User\SettingTest::testCheckInput.testCheckInput with data set #3
    Tests\Core\Command\User\SettingTest::testCheckInput.testCheckInput with data set #5
    Tests\Core\Command\User\SettingTest::testCheckInput.testCheckInput with data set #6
    Tests\Core\Command\User\SettingTest::testCheckInput.testCheckInput with data set #7
    Tests\Core\Command\User\SettingTest::testCheckInput.testCheckInput with data set #11
    Tests\Core\Command\User\SettingTest::testCheckInput.testCheckInput with data set #12
    Tests\Core\Command\User\SettingTest::testExecuteDelete.testExecuteDelete with data set #0
    Tests\Core\Command\User\SettingTest::testExecuteDelete.testExecuteDelete with data set #1
    Tests\Core\Command\User\SettingTest::testExecuteDelete.testExecuteDelete with data set #2
    Tests\Core\Command\User\SettingTest::testExecuteSet.testExecuteSet with data set #0
    Tests\Core\Command\User\SettingTest::testExecuteSet.testExecuteSet with data set #1
    Tests\Core\Command\User\SettingTest::testExecuteSet.testExecuteSet with data set #2
    Tests\Core\Command\User\SettingTest::testExecuteGet.testExecuteGet with data set #1

@DeepDiver1975
Copy link
Member Author

Will Work on failing Tests

@DeepDiver1975
Copy link
Member Author

Jenkins is green on this one @PVince81 @VicDeo @butonic merge?

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

👍 let's hope the version eyes will be happy now

@PVince81 PVince81 merged commit 0353150 into master Sep 7, 2016
@PVince81 PVince81 deleted the update-some-more-libs branch September 7, 2016 07:07
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants