BUG: pd.cut with duplicate index Series lowest included #42425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jreback
requested changes
Jul 7, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
pls always add tests for any change
Contributor
Author
|
Hi @jreback , apologies, I am new to open source contributions.
|
Contributor
|
we have extensive docummentation on how to do changes: https://pandas.pydata.org/pandas-docs/dev/development/index.html you need to add tests for your scenario and not break anything else. |
jreback
requested changes
Jul 8, 2021
pandas/tests/reshape/test_cut.py
Outdated
| tm.assert_series_equal(result, expected) | ||
|
|
||
|
|
||
| def df_from_series_with_nonexact_categoricalindices_frompdcut(): |
Contributor
There was a problem hiding this comment.
this won't execute as its not named correctly e.g. name similar to the above
pandas/core/reshape/tile.py
Outdated
|
|
||
| if include_lowest: | ||
| ids[x == bins[0]] = 1 | ||
| if isinstance(x, ABCSeries): |
Contributor
There was a problem hiding this comment.
try using
ids[np.asarray(x) == bins[0]] = 1 instead of the if/else
Co-authored-by: Jeff Reback <jeff@reback.net>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include_lowest=True#42185