CLN: Remove redundant call to get_splitter #4753
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/groupby.py
Outdated
Member
There was a problem hiding this comment.
Is there a particular reason you chose to remove this one and not the other? Maybe turn comp_ids into _ to indicate that it isn't being used anymore.
Author
There was a problem hiding this comment.
I removed the call that was not being used. The following call to the internal method was written a few days later and the intent seems to have been to replace this call.
The previous assignment is now redundant as well. It is repeated in _get_splitter(). I'll push a commit to remove it.
cpcloud
added a commit
that referenced
this pull request
Sep 6, 2013
CLN: Remove redundant call to get_splitter
Member
|
@kjordahl Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_splitterwas called directly, then again through an internal method. Results from the first call are not used for anything and immediately replaced.