Skip to content

CLN: Remove redundant call to get_splitter #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpcloud merged 2 commits into from
Sep 6, 2013
Merged

CLN: Remove redundant call to get_splitter #4753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b45bf4
CLN: Remove redundant call to get_splitter
Sep 5, 2013
c236076
CLN: Remove unused assignment
Sep 5, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pandas/core/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,9 +589,6 @@ def get_iterator(self, data, axis=0, keep_internal=True):
Generator yielding sequence of (name, subsetted object)
for each group
"""
comp_ids, _, ngroups = self.group_info
splitter = get_splitter(data, comp_ids, ngroups, axis=axis,
keep_internal=keep_internal)
splitter = self._get_splitter(data, axis=axis,
keep_internal=keep_internal)
Copy link
Member

@cpcloud cpcloud Sep 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason you chose to remove this one and not the other? Maybe turn comp_ids into _ to indicate that it isn't being used anymore.

Copy link
Author

@kjordahl kjordahl Sep 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the call that was not being used. The following call to the internal method was written a few days later and the intent seems to have been to replace this call.

The previous assignment is now redundant as well. It is repeated in _get_splitter(). I'll push a commit to remove it.

keys = self._get_group_keys()
Expand Down