Skip to content

Conversation

@donghyyun
Copy link
Contributor

@donghyyun donghyyun commented Oct 1, 2022

By default, the Resampler.mean docstring is inherited from GroupBy.mean. As a result, unsupported parameters 'engine' and 'engine_kwargs' were created in the API documentation.

To do this, I defined the Mean function as a method of Resampler and wrote the docstring of the function itself.

FYI: I think it is unnecessary to add this issue to the Whatsnew section, so I left it.

@mroeschke mroeschke assigned mroeschke and unassigned mroeschke Oct 3, 2022
@mroeschke mroeschke added Docs Resample resample method labels Oct 3, 2022
@donghyyun
Copy link
Contributor Author

@mroeschke
Is there anything I missed or need to revise?

@donghyyun donghyyun changed the title DOC: Added mean function as method of Resampler and updated docstring DOC: Added mean function as a method of Resampler and updated docstring Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Resample resample method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: Remove unsupported parameters in Resampler.mean

2 participants