DOC: Updated Resampler.mean docstring to have its own docstring #48980
Conversation
|
I found that doc build error also occurs in previous commit(#48965). |
phofl
left a comment
phofl
left a comment
There was a problem hiding this comment.
doc failure is related to a dependency
pandas/core/resample.py
Outdated
| numeric_only : bool, default False | ||
| Include only `float`, `int` or `boolean` data. | ||
| .. versionadded:: 1.5.0 |
There was a problem hiding this comment.
@phofl In var, std method, numeric_only versionadded is written. So I thought mean method also need versionadded. If it is wrong, I will fix it.
There was a problem hiding this comment.
var and std did not support this prior to 1.5, but this function was consistent with the groupby op that already supported this before. So you can remove it
There was a problem hiding this comment.
Thank you for comments. I removed it.
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
LGTM.
(As an aside, we should probably not auto-generate these methods for resample like we did groupby cc @rhshadrach)
mroeschke
added
Docs
Resample
|
Thanks @donghyyun |
…as-dev#48980) * DOC: Added mean function as method of Resampler and updated docstring * removed versionadded
3 participants
Resampler.mean#48803 which belongs toContributions welcomemilestoneBy default, the
Resampler.meandocstring is inherited fromGroupBy.mean. As a result, unsupported parameters 'engine' and 'engine_kwargs' were created in the API documentation.To do this, I defined the Mean function as a method of Resampler and wrote the docstring of the function itself.