Add pants.remote-cache.toml#11394
Merged
Eric-Arellano merged 2 commits intoJan 1, 2021
Merged
Conversation
[ci skip-build-wheels] [ci skip-rust]
Eric-Arellano
commented
Dec 29, 2020
Contributor
Author
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Split out of #11384. I removed all the setup for CI.
| remote_instance_name = "main" | ||
|
|
||
| # Normally, we wouldn't want this, but it's helpful while we iterate on remote caching to force the remote to be used. | ||
| process_execution_use_local_cache = false |
Contributor
Author
There was a problem hiding this comment.
This might be controversial to set in the config file. But I figure we can override it.
By the time we are confident enough to turn this on production, we can toggle it off.
stuhood
approved these changes
Dec 29, 2020
Comment on lines
+17
to
+19
| remote_store_initial_timeout = 250 | ||
| remote_store_timeout_multiplier = 1.5 | ||
| remote_store_maximum_timeout = 5000 |
Member
There was a problem hiding this comment.
Should these be adjustments to the default values? If not, explaining why we set them to non-defaults would be good.
Contributor
Author
There was a problem hiding this comment.
I have no idea. Blindly copied from Tom's PR.
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain is making improvements to remote caching, and this change facilitates setting that up to be used.
There are two contexts where we often use remote caching:
These have different settings, such as which server to point to. Instead of having two separate config files, we leave out the context-specific settings. Developers can use
.envrcto automatically set them, and in CI, we can set.travis.ymlappropriately.[ci skip-build-wheels]
[ci skip-rust]