Skip to content

Prepare the 2.3.0.dev0 release.#11446

Merged
jsirois merged 3 commits into
pantsbuild:masterfrom
jsirois:release/2.3.0.dev0/notes
Jan 11, 2021
Merged

Prepare the 2.3.0.dev0 release.#11446
jsirois merged 3 commits into
pantsbuild:masterfrom
jsirois:release/2.3.0.dev0/notes

Conversation

@jsirois
Copy link
Copy Markdown
Contributor

@jsirois jsirois commented Jan 10, 2021

[ci skip-rust]

@jsirois
Copy link
Copy Markdown
Contributor Author

jsirois commented Jan 10, 2021

Internal only changes:

  • Remove --stats-json-file (#11435)

  • Remove aggregated timings (#11431)

  • add histograms for observation metrics to work unit store (#11185)

  • Remove speculation of remote execution for now (#11428)

  • Upgrade toolchain pants plugin. (#11415)

  • Require the rust-std component in rustup. (#11422)

  • Set explicit required components for rustup. (#11420)

  • Delete reporting directory (#11414)

  • Remove still more obsolete runtracker code (#11412)

  • Implement ProcessMetadata::default() to clean up tests (#11410)

  • Remove more obsolete code from RunTracker (#11408)

  • Revert "Upgrade to Rust v1.49.0 (Upgrade to Rust v1.49.0 #11404)" (#11405)

  • Restore cargo audit CI job (#11403)

  • Upgrade to Rust v1.49.0 (#11404)

  • Add pants.remote-cache.toml (#11394)

  • Fix docstring deprecation warning for Bandit. (#11395)

  • Remove stale Google RBE config (#11384)

@jsirois
Copy link
Copy Markdown
Contributor Author

jsirois commented Jan 10, 2021

The release instructions say to put the internal only changes in the PR description. That makes for an awfully noisy commit message in the logs that serves no purpose that I can see except to re-capitulate code review conclusions. We do that for no other code review conclusion afaict.

Perhaps there is reasoning I'm missing.

@Eric-Arellano
Copy link
Copy Markdown
Contributor

The release instructions say to put the internal only changes in the PR description.

Feel free to update it to instead be a comment on the PR. Agreed, no need to be in the actual PR description - the intent was solely "document them in the PR so that it can be discussed."

Copy link
Copy Markdown
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I appreciate you splitting out those deprecation removals into dedicated PRs.

Comment thread src/python/pants/notes/2.3.x.md Outdated
Comment thread src/python/pants/notes/2.3.x.md Outdated

### Bug fixes

* Add `--remote-cache-eager-fetch` to reduce unreliability ([#11396](https://github.com/pantsbuild/pants/pull/11396))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better in new feature, but this works too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understood it this was a stopgap bugfix that would be replaced by better handling with no special feature / configuration use needed going forward.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how I viewed it at first too, but Benjy conjectured it may always be worth keeping if the performance is better. I removed the help message saying "we plan to deprecate this" after review feedback.

Comment thread src/python/pants/notes/2.3.x.md Outdated
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
@jsirois jsirois merged commit 4a0eb73 into pantsbuild:master Jan 11, 2021
@jsirois jsirois deleted the release/2.3.0.dev0/notes branch January 11, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants