Delete reporting directory#11414
Merged
Merged
Conversation
The only remaining source file here is streaming_workunit_handler.py, which this commit moves to within /engine. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Jan 6, 2021
Member
|
I'm fairly surprised that this didn't break the TC plugin, but it appears not to have. I'm not sure how the plugin is still loading it from the previous location... |
Member
|
Ok, so this did actually cause some confusion. The reason that the TC plugin didn't break is that it is probably (?) bringing in its own separate copy of the moved code in its old locations. @tdyas was able to figure out that there were two different definitions of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only remaining source file here is streaming_workunit_handler.py, which this commit moves to within /engine.