Remove --stats-json-file options

[gshuflin]

In a recent commit, the RunTracker-specific option to write build stats to a JSON file was deprecated and its functionality moved to a new global option --stats-json-file. But in modern pants the ability to write this JSON file isn't particularly useful, so we might as well remove it and the code that supports it.

[gshuflin]

cf. #11432 (comment)

[Eric-Arellano]

The old option was deprecated in 2.2 and removed in 2.3. But the new option was added.

We are now on 2.3 dev. Per the deprecation policy, we're supposed to deprecate the new option --stats-json-file until 2.4.0.dev0.

[gshuflin]

The old option was deprecated in 2.2 and removed in 2.3. But the new option was added.

We are now on 2.3 dev. Per the deprecation policy, we're supposed to deprecate the new option --stats-json-file until 2.4.0.dev0.

--stats-json-file was added in a commit yesterday (9cde7c0#diff-db4651ae839e702898bac44a00db5fd93b21701f624f57479fb537d7bc55a6d1R423) , and there hasn't been a release since then. So I think it is okay to remove the option without going through the deprecation process. No version of pants has been released with this option, and the only way anyone would've seen it is if they were using pants on the latest master in the past 24 hours or so.

[Eric-Arellano]

Ah, cool. Sg!