Skip to content

Upgrade toolchain pants plugin.#11415

Merged
stuhood merged 3 commits into
pantsbuild:masterfrom
asherf:bosco
Jan 6, 2021
Merged

Upgrade toolchain pants plugin.#11415
stuhood merged 3 commits into
pantsbuild:masterfrom
asherf:bosco

Conversation

@asherf
Copy link
Copy Markdown
Member

@asherf asherf commented Jan 6, 2021

This update contains many internal improvments and refactorings and also remove the use of Subsystem.global_instance() from the plugin.

Copy link
Copy Markdown
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stuhood
Copy link
Copy Markdown
Member

stuhood commented Jan 6, 2021

#11420 should help with the failing OSX shard here.

@stuhood
Copy link
Copy Markdown
Member

stuhood commented Jan 6, 2021

Once this is in, I'll get out the deprecation removal for Subsystem.{global_instance,scoped_instance}().

@stuhood
Copy link
Copy Markdown
Member

stuhood commented Jan 6, 2021

Sorry for the whack-a-mole. Another fix coming in #11422.

@stuhood stuhood merged commit 6b24d20 into pantsbuild:master Jan 6, 2021
@asherf asherf deleted the bosco branch January 7, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants