Remove more obsolete code from RunTracker#11408
Merged
Merged
Conversation
_stast() and _json_dump_options() [ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
And explicitly settings `is_tool` - it will always be False, since this is a piece of data that is no longer relevant. [ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RunTrackerstill has a lot of code paths many years old that have been obsolete for a long time.Solution
This commit consolidates several methods on
RunTrackerthat are being called in only one place, adds type annotations to functions that did not previously have them, and removing code that pertains to the old Python-onlyWorkUnitclass (unrelated to Rust-level engine workunits).Result
Nothing in this change should be user-visible.