Update guidance for internal changes.#11447
Merged
jsirois merged 1 commit intoJan 11, 2021
Merged
Conversation
Instead of suggesting internal only commits are forever memorialized in the commit message, suggest they be included in a comment for reviewers to scrutinize. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Contributor
Author
|
Motivating discussion here: #11446 (comment) |
jsirois
requested review from
Eric-Arellano and
cattibrie
and removed request for
cattibrie
Eric-Arellano
approved these changes
Jan 11, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of suggesting internal only commits are forever memorialized
in the commit message, suggest they be included in a comment for
reviewers to scrutinize.
[ci skip-rust]
[ci skip-build-wheels]