fix: right-side StackOverlay window preview not showing#458
Closed
jtaala wants to merge 1 commit intopaperwm:developfrom
Closed
fix: right-side StackOverlay window preview not showing#458jtaala wants to merge 1 commit intopaperwm:developfrom
jtaala wants to merge 1 commit intopaperwm:developfrom
Conversation
used scale and clone.width instead of 'get_transformed_size()').
Collaborator
Author
|
@Gelbana @tadfisher @ccope @smichel17 - apologies for the lot of PRs I'm pinging you about! but here's another quick fix for review that fixes the right-side stack overlay from not showing. I'm not 100% sure why In any case the proposed fix should be a much more direct/robust way for calculating the clone's x position for the right-side preview. |
Collaborator
Author
jtaala
deleted the
fix-issue457-right-side-stackoverlay-preview-not-working
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457.
Sets right-side window preview's x position directly (using the used scale and
clone.widthinstead ofget_transformed_size()).