Make minimap scale (size) user-configurable through PaperWM extension settings#454
Conversation
independent of MINIMAP_SCALE (preparation for setting scale to user option). Added "minimap-scale" to schema (and recompiled schema). Minimap.js now uses "prefs.minimap_scale" from schema. Added "Mini-map scale (size)" GtkSpinButton to settings.ui and implemented binding in prefs.js.
interface guidelines.
used scale and clone.width instead of 'get_transformed_size()').
…g' into minimap-scale-user-configurable
… scale value for StackOverlay window previews.
|
@Gelbana @tadfisher @ccope @smichel17 - here's a new feature to review when someone has time. This one allows users to set the minimap scale in extension settings. Note this PR also implements fix #458 and sets the the StackOverlay preview size to the user defined scale. |
…ay (in extension settings) to percentage format (e.g. `30` instead of `0.3`).
|
@smichel17 to align with the other PRs (like #453 and #456) I've changed the setting value display (in extension settings) to also be percentage format (e.g. Cheers! |
|
All, this has been up and ready to go for 3 weeks - did the invites for comment and haven't heard any complaints etc. Have been testing this new feature in anger for the past 3 weeks and haven't seen any regressions or issues. Will merge this now. |
|
This looks good to me, no suggestions. I have two comments for the future, though:
|
|
Yeah, good points - this setting seemed simple enough and fit well enough to add it to the "Settings" section (p.s. it used to be called "Toggles"). Re the "Useful window widths/heights" - yeah I struggled a bit with knowing where to stick them... I toyed with creating a new settings section or tab - in the end I thought where they ended up was kind of okay (but not ideal). |
|
Agreed that it's good enough for now, with how few settings there are. The more settings, the better they need to be organized. |
This PR makes the mini-map size user configurable. It also fixes #457 and uses the user defined mini-map scale value for StackOverlay window previews as well.
I prefer the mini-map tile size to be a little larger than the current default (15%). This PR adds a setting to PaperWM extension settings which allows users to select their own mini-map scale setting (from 5% to 95%).
This setting corresponds to the "scale" of mini-map tiles as compared to their actual window size (e.g. "15" corresponds to a mini-map tile size being approximately 15% of the actual window size).
Changes are applied immediately (no need to logout/login etc.).
The default value is set to the original MINIMAP_SCALE value that was defined in minimap.js.