Adds user configurable tiling edge margins to PaperWM extension settings ui#467
Adds user configurable tiling edge margins to PaperWM extension settings ui#467jtaala wants to merge 6 commits intopaperwm:developfrom
Conversation
signal interception.
screen so users can visualise edge tiling margin changes.
|
@smichel17 - given our conversation in #454 and #456 re user settings - what do you think of this one? I think this one definitely fits - as it's a margin. Also, interestingly I've noticed that it's one of the first things that seems "off" to new users, although it's intended behaviour to let users know when they are a tiling edge. I prefer Anyways, we could leave this one there and move or remove the |
|
I think this is one we can fix without a setting. I'll reply in #364 |
Thanks @smichel17! I don't think it's a bug though, it's a feature! :-). I added a comment to #364 outlining why I chose to have it as a simple user-defined preference setting (which is fit nicely in the settings ui with the margin settings). |
|
I tested this and it seems to work without issues. I set the margin to 5px and I also have the other margins set to 5px. So there is no space between the borders and the edge of the screen. |
…sed no margin to be shown (#488) Closes #364. This PR was created since @basdelfos develop branch/fork isn't available anymore :-( Please see #364 for details of this. It has been a long time coming. Given the merging of #471 (an improved way to see the window position), and also the merging of #473, having no margin on the left/right tiling edge no longer provides the original benefit (of seeing when you're at an tiling edge). This simply removes the cases where no left/right margin would be shown - which also cleans-up/simplifies this area of code (thanks @smichel17 ). Note: we will close #467 as it was originally a way to set this separately. However we will be closing that in favour of this one.
Closes #364
This PR adds user configurable tiling edge margins to the settings ui. Edge margins are the minimum margin from screen edges to the leftmost and rightmost window edges. Currently the edge margin is set to 0px (by design).
Edge margins were discussed in #364, with some users preferring having an edge margin. This PR allows users to:
Video demonstration of changing edge margins:
paperwm-tiling-edge-margin.mp4
NOTE: this PR has been implemented in the PaperWM-redux fork, which you can install if you want this, or any of my other open PRs.