Show next stackoverlay window preview when switching to offscreen window with mouse#473
Merged
jtaala merged 2 commits intopaperwm:developfrom Mar 2, 2023
Conversation
preview. Note, removes timeout limit on preview show as long as mouse in against window edge.
next window preview. Resolves corner case where pointer could be moved away during animation delay.
Collaborator
Author
|
Merging this in now given some time has passed and no comments. I've been running this in anger since creating this PR. Haven't had issues. If you run into issues please report. |
jtaala
added a commit
that referenced
this pull request
Mar 15, 2023
…sed no margin to be shown (#488) Closes #364. This PR was created since @basdelfos develop branch/fork isn't available anymore :-( Please see #364 for details of this. It has been a long time coming. Given the merging of #471 (an improved way to see the window position), and also the merging of #473, having no margin on the left/right tiling edge no longer provides the original benefit (of seeing when you're at an tiling edge). This simply removes the cases where no left/right margin would be shown - which also cleans-up/simplifies this area of code (thanks @smichel17 ). Note: we will close #467 as it was originally a way to set this separately. However we will be closing that in favour of this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #470.
This PR automatically shows the next stackoverlay window preview (if window exists) when a user clicks with the current preview. Previous behaviour did not show the next window preview meaning users had to move the mouse away, and then back against the screen edge to show the next preview.
Note: I've also removed the 2 second timeout on showing next window previews. This feels better to me - but please comment if you think the original (2 second timeout for previews) is better.
NOTE: this PR has been implemented in the PaperWM-redux fork, which you can install if you want this, or any of my other open PRs.