Skip to content

Replaces #364: removes the left and right tiling restriction that caused no margin to be shown#488

Merged
jtaala merged 1 commit intodevelopfrom
remove-tiling-edge-margin
Mar 15, 2023
Merged

Replaces #364: removes the left and right tiling restriction that caused no margin to be shown#488
jtaala merged 1 commit intodevelopfrom
remove-tiling-edge-margin

Conversation

@jtaala
Copy link
Copy Markdown
Collaborator

@jtaala jtaala commented Mar 11, 2023

Closes #364.

This PR was created since @basdelfos develop branch/fork isn't available anymore :-(

Please see #364 for details of this. It has been a long time coming. Given the merging of #471 (an improved way to see the window position), and also the merging of #473, having no margin on the left/right tiling edge no longer provides the original benefit (of seeing when you're at an tiling edge).

This simply removes the cases where no left/right margin would be shown - which also cleans-up/simplifies this area of code (thanks @smichel17 ).

Note: we will close #467 as it was originally a way to set this separately. However we will be closing that in favour of this one.

be shown.  Essentially completes #364 which isn't available anymore
(original submiiter removed his fork a while back).
Copy link
Copy Markdown
Collaborator

@Lythenas Lythenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been running these changes for a couple of days and it seems to work without issues,

@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Mar 15, 2023
@jtaala jtaala merged commit 416fa32 into develop Mar 15, 2023
@jtaala jtaala deleted the remove-tiling-edge-margin branch March 15, 2023 22:31
jtaala added a commit to PaperWM-redux/PaperWM that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merging soon Label for PRs that are planned to be merged soon (usually within the next week)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants