Conversation
This command updates substrate's UI tests, which is a routine step we have to perform during every rust toolchain upgrade.
|
|
||
| # This script uses rustup to install the required rust version. | ||
| # Doing that in CI feels rather ugly, but sadly there's currently no mechanism | ||
| # in command-bot to use a different CI image for individual jobs, so this is |
There was a problem hiding this comment.
This sounds like a nice feature to have.
@mordamax currently we're using paritytech/ci-linux:production, as far as I understand.
But does anything stop us from allowing that to be configured in the command scripts?
There was a problem hiding this comment.
sorry may be i don't get this question
isn't setting tag in .cmd.json linux-docker-vm-c2 to something else lets to change the image?
There was a problem hiding this comment.
I thought it changes the machine to execute the job on, not the image...
There was a problem hiding this comment.
yea while i thought different machine would have different image
but yea, you're right, now i paid attention that we have this configured on the app level
process.env.GITLAB_JOB_IMAGE ??= "paritytech/ci-linux:production"yea, technically abs possible to make it as part of .cmd.json, but would that be ok overall? i mean secure etc
There was a problem hiding this comment.
Yeah, that'd be useful, and no particular security concern. (For example, the CI image for normal CI jobs is configured in the .gitlab-ci.yml of the repo being tested; being able to configure it here in command-bot-scripts is no worse than that.)
There was a problem hiding this comment.
yea i can add it then to a .cmd.json config
There was a problem hiding this comment.
3 participants
This command updates substrate's UI tests, which is a routine step we have to perform during every rust toolchain upgrade.