Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

update UI tests to support rust 1.70#14389

Closed
sam0x17 wants to merge 1 commit intomasterfrom
sam-update-rust-1-70
Closed

update UI tests to support rust 1.70#14389
sam0x17 wants to merge 1 commit intomasterfrom
sam-update-rust-1-70

Conversation

@sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Jun 14, 2023

Updating rust to 1.70

dependent on https://github.com/paritytech/ci_cd/issues/816

@sam0x17 sam0x17 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. rust Pull requests that update Rust code labels Jun 14, 2023
@sam0x17 sam0x17 self-assigned this Jun 14, 2023
@sam0x17 sam0x17 requested review from a team June 14, 2023 15:42
@sam0x17 sam0x17 removed the rust Pull requests that update Rust code label Jun 14, 2023
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can get bot update-ui eventually.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2993280

@altaua
Copy link
Contributor

altaua commented Jun 19, 2023

Maybe we can get bot update-ui eventually.

Done! paritytech/command-bot-scripts#37

@altaua
Copy link
Contributor

altaua commented Jun 19, 2023

This is outdated, there have been ui test changes in the meantime. Let's get #14399 merged instead, that contains both ui test updates and all other changes required for 1.70 in one atomic bundle.

@altaua altaua closed this Jun 19, 2023
@altaua altaua deleted the sam-update-rust-1-70 branch June 20, 2023 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants