Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

ci: bump ci image for rust 1.70#14399

Merged
altaua merged 3 commits intomasterfrom
mira/rust-1.70
Jun 20, 2023
Merged

ci: bump ci image for rust 1.70#14399
altaua merged 3 commits intomasterfrom
mira/rust-1.70

Conversation

@altaua
Copy link
Contributor

@altaua altaua commented Jun 15, 2023 •
edited
Loading

@altaua altaua added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 15, 2023
@altaua altaua self-assigned this Jun 15, 2023
@paritytech paritytech deleted a comment from command-bot bot Jun 15, 2023
@paritytech paritytech deleted a comment from command-bot bot Jun 15, 2023
@paritytech paritytech deleted a comment from command-bot bot Jun 15, 2023
@paritytech paritytech deleted a comment from command-bot bot Jun 15, 2023
@gilescope
Copy link
Contributor

gilescope commented Jun 16, 2023

Nice. #14334 should mean that it builds without warnings now.

@altaua

This comment was marked as outdated.

Sign in to view
@command-bot

This comment was marked as outdated.

Sign in to view
@paritytech paritytech deleted a comment from command-bot bot Jun 16, 2023
@paritytech paritytech deleted a comment from command-bot bot Jun 16, 2023
@command-bot

This comment was marked as outdated.

Sign in to view
@gilescope gilescope mentioned this pull request Jun 16, 2023
Merged
@altaua
Copy link
Contributor Author

altaua commented Jun 19, 2023

bot update-ui $ 1.70

@command-bot
Copy link

command-bot bot commented Jun 19, 2023 •
edited
Loading

@altaua https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3023094 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" 1.70. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-2ea903d7-89be-4b8a-93ad-accb218c33bc to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@altaua Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" 1.70 has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3023094 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3023094/artifacts/download.

@altaua altaua force-pushed the mira/rust-1.70 branch 3 times, most recently from ca4f079 to d7c4e94 Compare June 19, 2023 15:12
@altaua altaua mentioned this pull request Jun 19, 2023
Closed
@altaua altaua added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jun 19, 2023
@altaua altaua marked this pull request as ready for review June 19, 2023 15:59
@altaua altaua requested review from a team June 19, 2023 15:59
@altaua altaua requested a review from a team as a code owner June 19, 2023 15:59
@altaua altaua added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jun 19, 2023
ggwpez
ggwpez approved these changes Jun 19, 2023
View reviewed changes
@paritytech-ci paritytech-ci requested a review from a team June 19, 2023 16:08
sam0x17
sam0x17 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@altaua altaua merged commit 242858f into master Jun 20, 2023
@altaua altaua deleted the mira/rust-1.70 branch June 20, 2023 11:26
@gilescope
Copy link
Contributor

gilescope commented Jun 22, 2023

https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3051557 - looks like one of the CI jobs is still using the old rust version.

nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@nathanwhit
ci: bump ci image for rust 1.70 (paritytech#14399)
dbc6a8f 
* ci: bump ci image for rust 1.70

* ".git/.scripts/commands/update-ui/update-ui.sh" 1.70

* chore: ignore the new let_with_type_underscore lint

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

@alvicsam alvicsam alvicsam approved these changes

@mateo-moon mateo-moon mateo-moon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@altaua altaua

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@altaua @gilescope @sam0x17 @bkchr @ggwpez @alvicsam @mateo-moon