Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

changelog: update template for new label behavior (E3/E4)#6804

Merged
coderobe merged 3 commits intomasterfrom
coderobe/changelog-hostfunc
Mar 6, 2023
Merged

changelog: update template for new label behavior (E3/E4)#6804
coderobe merged 3 commits intomasterfrom
coderobe/changelog-hostfunc

Conversation

@coderobe
Copy link
Contributor

@coderobe coderobe commented Mar 1, 2023

This distinguishes E3 and E4 labels in the changelog output

@coderobe
update changelog template for new label behavior (E3/E4)
fc58fb5 
This distinguishes E3 and E4 labels in the changelog output
@coderobe coderobe requested a review from a team March 1, 2023 14:19
@coderobe coderobe added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 1, 2023
chevdor
chevdor reviewed Mar 1, 2023
View reviewed changes
scripts/ci/changelog/templates/host_functions.md.tera Outdated
Comment on lines +25 to +29
{%- if upgrade_first != 0 %}
⚠️ There is a runtime change that will require nodes to be update BEFORE the runtime upgrade.

⚠️ It is critical that you update your client before the chain switches to the new runtime.
{% elif host_fn_count == 0 %}
Copy link
Contributor

@chevdor chevdor Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no rule preventing from having E3 and E4 together, this is fine IMO.

I would suggest to have 2 independant sections, one for E3 saying on a "note" level that there is a new host fn and one for E4 which is basically the big warning we have already.

This way we cover all the cases:

  • E3 alone
  • E3 + E4 together
  • E4 alone

Copy link
Contributor Author

@coderobe coderobe Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep that all in this template file or create a new one? I'd just put it all in here if there are no objections to that.

Copy link
Contributor

@chevdor chevdor Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave it to you, as long as the one template does not explode in size, we can keep it in the same file, that's fine.
I would extract it as macro if it would be used in several places but I don't think it is.

Copy link
Contributor Author

@coderobe coderobe Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look? I've separated the sections and changed the host function section to use ℹ️ instead of ⚠️

@coderobe coderobe changed the title update changelog template for new label behavior (E3/E4) changelog: update template for new label behavior (E3/E4) Mar 1, 2023
@coderobe coderobe added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). T8-release This PR/Issue is related to topics touching the release notes. and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Mar 1, 2023
@coderobe coderobe requested a review from a team March 3, 2023 14:51
@coderobe coderobe marked this pull request as ready for review March 3, 2023 14:51
@coderobe coderobe requested a review from a team as a code owner March 3, 2023 14:51
@coderobe coderobe added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 3, 2023
chevdor
chevdor approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change !

@paritytech-ci paritytech-ci requested a review from a team March 3, 2023 15:50
@coderobe coderobe enabled auto-merge (squash) March 3, 2023 15:54
@coderobe coderobe merged commit 0f4f350 into master Mar 6, 2023
@coderobe coderobe deleted the coderobe/changelog-hostfunc branch March 6, 2023 19:36
ordian added a commit that referenced this pull request Mar 7, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-client
5046c2d 
* master: (27 commits)
  bump `zombienet` version to v1.3.37 (#6773)
  Bump `blake2b_simd` to 1.0.1 (#6829)
  changelog: update template for new label behavior (E3/E4) (#6804)
  Companion for paritytech/substrate#12828 (#6380)
  Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727)
  Polkadot XCM Body constants (#6788)
  Decrease expected peer count in zombinenet tests (#6826)
  Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)
  Change node-key for bootnodes (#6772)
  Change handle_import_statements to FatalResult (#6820)
  Introduce XCM matcher for writing barriers (#6756)
  Freeze note on `SessionInfo`. (#6818)
  Bump parity-db (#6816)
  Removing Outdated References to Misbehavior Arbitration Subsystem (#6814)
  Forgotten re-export for `MatchedConvertedConcreteId` (#6815)
  Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809)
  Migrate to `Weight::from_parts` (#6794)
  [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739)
  Get rid of unnecessary cloning and work. (#6808)
  changelog: fix migration listing (#6806)
  ...
ordian added a commit that referenced this pull request Mar 7, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
f2119e4 
* master: (27 commits)
  bump `zombienet` version to v1.3.37 (#6773)
  Bump `blake2b_simd` to 1.0.1 (#6829)
  changelog: update template for new label behavior (E3/E4) (#6804)
  Companion for paritytech/substrate#12828 (#6380)
  Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727)
  Polkadot XCM Body constants (#6788)
  Decrease expected peer count in zombinenet tests (#6826)
  Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)
  Change node-key for bootnodes (#6772)
  Change handle_import_statements to FatalResult (#6820)
  Introduce XCM matcher for writing barriers (#6756)
  Freeze note on `SessionInfo`. (#6818)
  Bump parity-db (#6816)
  Removing Outdated References to Misbehavior Arbitration Subsystem (#6814)
  Forgotten re-export for `MatchedConvertedConcreteId` (#6815)
  Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809)
  Migrate to `Weight::from_parts` (#6794)
  [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739)
  Get rid of unnecessary cloning and work. (#6808)
  changelog: fix migration listing (#6806)
  ...
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
@librelois librelois mentioned this pull request Apr 6, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chevdor chevdor chevdor approved these changes

@sergejparity sergejparity sergejparity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. T8-release This PR/Issue is related to topics touching the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coderobe @chevdor @sergejparity