This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Move PVF timeouts to executor environment parameters#6823
Merged
paritytech-processbot[bot] merged 12 commits intomasterfrom Mar 8, 2023
Merged
Move PVF timeouts to executor environment parameters#6823paritytech-processbot[bot] merged 12 commits intomasterfrom
paritytech-processbot[bot] merged 12 commits intomasterfrom
Conversation
s0me0ne-unkn0wn
added
B0-silent
mrcnski
reviewed
Mar 5, 2023
mrcnski
suggested changes
Mar 6, 2023
Contributor
mrcnski
left a comment
mrcnski
left a comment
There was a problem hiding this comment.
Really like this change! I mostly left a bunch of nits and a few questions.
node/core/pvf/src/prepare/queue.rs
Outdated
| priority, | ||
| pvf_with_params: PvfWithExecutorParams::from_discriminator(3), | ||
| preparation_timeout: LENIENT_PREPARATION_TIMEOUT, | ||
| pvf: PvfExhaustive::from_discriminator_and_timeout(3, TEST_PREPARATION_TIMEOUT * 3), |
Contributor
There was a problem hiding this comment.
Maybe use TEST_LENIENT_PREPARATION_TIMEOUT instead? (Below too.)
* Changing dispute db errors to fatal * fmt
…ordinator` (#6775) * Additional tracing in `provisioner`, `vote_selection` * Add `fetched_onchain_disputes` metric to provisioner * Some tracelines in dispute-coordinator TODO: cherry pick this in the initial branch!!! * Remove spammy logs * Remove some trace lines
ordian
reviewed
Mar 6, 2023
mrcnski
reviewed
Mar 7, 2023
ordian
reviewed
Mar 7, 2023
eskimor
approved these changes
Mar 7, 2023
Contributor
Author
|
bot merge |
ordian
added a commit
that referenced
this pull request
Mar 16, 2023
* master: (50 commits) Issue 4393: Correcting Unnecessary Use of Arc (#6882) Companion for #13287 (#6655) timestamp ci job logs (#6890) Release parachain host API v4 (#6885) polkadot companion: #13128 (Pools commission) (#6264) companion for #13555 (#6842) Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600) Bump bumpalo from 3.8.0 to 3.12.0 (#6599) Bump git2 from 0.16.0 to 0.16.1 (#6601) Council as SpendOrigin (#6877) PVF: Document that preparation cannot lead to disputes (#6873) Sync versions with current release (0.9.39) (#6875) Companion for paritytech/substrate#13592 (#6869) Update orchestra to the recent version (#6854) Delete unused Cargo.lock (#6870) Remove use of Store trait (#6835) Companion for Substrate #13564 (#6845) Adding Dispute Participation Metrics (#6838) Update `substrate` to 48e7cb1 (#6851) Move PVF timeouts to executor environment parameters (#6823) ...
ordian
added a commit
that referenced
this pull request
Mar 21, 2023
…slashing-client * ao-past-session-slashing-runtime: (23 commits) Issue 4393: Correcting Unnecessary Use of Arc (#6882) Companion for #13287 (#6655) timestamp ci job logs (#6890) Release parachain host API v4 (#6885) polkadot companion: #13128 (Pools commission) (#6264) companion for #13555 (#6842) Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600) Bump bumpalo from 3.8.0 to 3.12.0 (#6599) Bump git2 from 0.16.0 to 0.16.1 (#6601) Council as SpendOrigin (#6877) PVF: Document that preparation cannot lead to disputes (#6873) Sync versions with current release (0.9.39) (#6875) Companion for paritytech/substrate#13592 (#6869) Update orchestra to the recent version (#6854) Delete unused Cargo.lock (#6870) Remove use of Store trait (#6835) Companion for Substrate #13564 (#6845) Adding Dispute Participation Metrics (#6838) Update `substrate` to 48e7cb1 (#6851) Move PVF timeouts to executor environment parameters (#6823) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6793
PVF execution and preparation timeouts are stored in the executor environment parameters and are applied per session.