This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add field names to pallet Event variants#10184
Merged
paritytech-processbot[bot] merged 9 commits intoparitytech:masterfrom Nov 15, 2021
Merged
Conversation
|
User @ayevbeosa, please sign the CLA here. |
athei
added
A0-please_review
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
… ayevbeosa-struct-variants-with-named-fields
athei
approved these changes
Nov 5, 2021
emostov
reviewed
Nov 10, 2021
emostov
approved these changes
Nov 10, 2021
Member
|
@ayevbeosa You need to merge master and resolve conflict before we can merge. |
Contributor
Author
Doing so now. |
… ayevbeosa-struct-variants-with-named-fields � Conflicts: � Cargo.lock
Member
|
bot merge |
Member
|
/tip small |
|
Please fix the following problems before calling the tip bot again:
|
Member
|
@ayevbeosa You need to provide an address in your opening post to receive a tip. Like here. |
Contributor
Author
This has been done. Thanks for the tip. |
Member
|
/tip small |
|
A small tip was successfully submitted for ayevbeosa (12dVgRw6ntsMQiETAoCBzu6MA7LPWagvU4Y1rH9jGPDHQvPX on polkadot). |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Changed named fields to struct variants * Fixed errors. * Made adjustments as per `cargo +nightly fmt`. * Update frame/uniques/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Removed redundant comments for structs. * Moved frame-support to dev dependencies Co-authored-by: Alexander Theißen <alex.theissen@me.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Changed named fields to struct variants * Fixed errors. * Made adjustments as per `cargo +nightly fmt`. * Update frame/uniques/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Removed redundant comments for structs. * Moved frame-support to dev dependencies Co-authored-by: Alexander Theißen <alex.theissen@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the pallet
Eventsvariants from tuples tostructswith named fields.Part implementation for #9903 and #9993.
Pallets With Changes
Polkadot address: 12dVgRw6ntsMQiETAoCBzu6MA7LPWagvU4Y1rH9jGPDHQvPX