This repository was archived by the owner on Nov 15, 2023. It is now read-only.
tuple to struct event variants#10206
Merged
paritytech-processbot[bot] merged 14 commits intoparitytech:masterfrom Nov 11, 2021
Doordashcon:ddc-AFNPEV-T2
Merged
tuple to struct event variants#10206paritytech-processbot[bot] merged 14 commits intoparitytech:masterfrom Doordashcon:ddc-AFNPEV-T2
paritytech-processbot[bot] merged 14 commits intoparitytech:masterfrom
Doordashcon:ddc-AFNPEV-T2
Conversation
|
User @Doordashcon, please sign the CLA here. |
shawntabrizi
reviewed
Nov 8, 2021
shawntabrizi
approved these changes
Nov 8, 2021
Member
|
/tip small |
|
Please fix the following problems before calling the tip bot again:
|
shawntabrizi
added
B0-silent
Contributor
Author
|
{polkadot} address: {12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h} |
Contributor
|
@Doordashcon you need to put it in your PR description, not as a comment. I've edited your PR post to include your DOT address. Also take note of the format, i.e. no braces are required. |
KiChjang
approved these changes
Nov 9, 2021
Contributor
Author
Thanks for the tip, PR updated |
shawntabrizi
approved these changes
Nov 11, 2021
Member
|
/tip small |
|
A small tip was successfully submitted for Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot). |
Contributor
|
Need to run |
KiChjang
added
A8-mergeoncegreen
and removed
A0-please_review
Contributor
|
bot merge |
|
Waiting for commit status. |
Contributor
|
Do we know if this is going to cause any compatibility concerns on client side? |
ordian
added a commit
that referenced
this pull request
Nov 12, 2021
* master: (27 commits) Bump rustversion from 1.0.4 to 1.0.5 (#10243) Kill the light client, CHTs and change tries. (#10080) tuple to struct event variants (#10206) Bump thiserror from 1.0.26 to 1.0.30 (#10240) Warn about usage of pallet collective set members call. (#10156) Bump git2 from 0.13.22 to 0.13.23 (#10238) Add group name in task metrics (#10196) Bump proc-macro-crate from 1.0.0 to 1.1.0 (#10237) Bump parity-util-mem from 0.10.0 to 0.10.2 (#10236) Bump substrate-bip39 from 0.4.2 to 0.4.4 (#10213) Upgrade jsonrpsee to v0.4.1 (#10022) expose substrate-cli service (#10229) Intend to reactivate cargo-unleash check (#10167) CI: build docs with deps (#9884) use CountedMap in pallet-bags-list (#10179) Move all example pallets under `examples` folder. (#10215) Upgrade wasm builder (#10226) upgrade ss58-registry with additional networks. (#10224) move wiki -> docs (#10225) new remote-ext mode: (#10192) ...
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* update sudo pallet * Update mock.rs * cargo +nightly fmt * frame-support remote-externalities * AFNPEV tips * AFNPEV bin & update sudo * cargo +nightly fmt * optional dependency remote-test feature * fmt Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* update sudo pallet * Update mock.rs * cargo +nightly fmt * frame-support remote-externalities * AFNPEV tips * AFNPEV bin & update sudo * cargo +nightly fmt * optional dependency remote-test feature * fmt Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the pallet Events variants from tuples to structs with named fields.
Part implementation for #9903, #9993 & #10184
Pallets with changes
polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h