This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Don't generate the consensusEngine field in chain specs#10303
Merged
paritytech-processbot[bot] merged 1 commit intoparitytech:masterfrom Nov 19, 2021
Merged
Conversation
tomaka
added
A0-please_review
bkchr
approved these changes
Nov 18, 2021
Member
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for cffc254 |
Member
|
bot merge |
|
Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count |
![paritytech-processbot[bot]](https://avatars.githubusercontent.com/in/144942?s=60&v=4){kind=small}
Contributor
|
Could we maybe keep generating the key until most clients don't require it anymore? |
Member
|
Just add the key manually. |
Contributor
Of course that's possible in principle, but that's not how polkadot-launch works. (it generates chainspecs that it then uses without any chance to edit manually) |
23 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
consensusEnginefield of chain specs hasn't been used in years. Let's no longer generate it, and allow decoding chain specs that don't have this field.