Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Put back consensus_engine, only accept its absence#10345

Merged
bkchr merged 1 commit intoparitytech:masterfrom
tomaka:revert-10303
Nov 23, 2021
Merged

Put back consensus_engine, only accept its absence#10345
bkchr merged 1 commit intoparitytech:masterfrom
tomaka:revert-10303

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 23, 2021

Continuation of #10303 (comment)

Substrate will now accept when the field is missing, but still generate chain specs with this field.
We'll remove the field in a later version.

@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 23, 2021
@tomaka tomaka requested review from apopiak and bkchr November 23, 2021 07:56
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@bkchr bkchr merged commit 0925218 into paritytech:master Nov 23, 2021
@tomaka tomaka deleted the revert-10303 branch November 23, 2021 09:19
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants