This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
Contributor
Author
|
Still in progress. |
Contributor
Author
|
@kianenigma Could you review this? |
kianenigma
reviewed
Jul 14, 2022
kianenigma
reviewed
Jul 14, 2022
kianenigma
reviewed
Jul 14, 2022
kianenigma
reviewed
Jul 14, 2022
kianenigma
reviewed
Jul 14, 2022
kianenigma
reviewed
Jul 14, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Looks in the right path! just needs to make sure it handles non-existent members correctly.
kianenigma
added
A0-please_review
Contributor
|
Also, needs a companion that adds it to Polkadot. |
Contributor
Author
I will give it a try. |
kianenigma
approved these changes
Jul 24, 2022
Contributor
|
\tip medium |
Contributor
|
/tip medium |
|
A medium tip was successfully submitted for Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot). https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips |
bkchr
approved these changes
Jul 25, 2022
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Contributor
Author
|
@kianenigma Should I make a new PR when we merge this for the pool's total pending rewards endpoint? |
Contributor
I am not sure if it is possible, therefore I removed my comment. |
kianenigma
reviewed
Jul 26, 2022
kianenigma
approved these changes
Jul 26, 2022
Szegoo
added a commit
to Szegoo/substrate-docs
that referenced
this pull request
Aug 4, 2022
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* rpc pending rewards * commit * remove unused imports * fix * fix * fmt * fix * fmt * fix * docs * docs & formatting * better formatting * temporary fix * error handling * fix? * fmt * use to_string * fmt * fixed error handling * fix * rpc added to client * Update Cargo.toml * Update Cargo.toml * fix wrong reward counter * expose function * move implementation * docs * docs * docs * Update lib.rs * Update lib.rs * unexpose functions * unused dependency * update Cargo.lock * Update frame/nomination-pools/src/lib.rs * Update lib.rs * Update lib.rs * Update frame/nomination-pools/rpc/runtime-api/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * remove rpc * remove rpc directory * final fix Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* rpc pending rewards * commit * remove unused imports * fix * fix * fmt * fix * fmt * fix * docs * docs & formatting * better formatting * temporary fix * error handling * fix? * fmt * use to_string * fmt * fixed error handling * fix * rpc added to client * Update Cargo.toml * Update Cargo.toml * fix wrong reward counter * expose function * move implementation * docs * docs * docs * Update lib.rs * Update lib.rs * unexpose functions * unused dependency * update Cargo.lock * Update frame/nomination-pools/src/lib.rs * Update lib.rs * Update lib.rs * Update frame/nomination-pools/rpc/runtime-api/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * remove rpc * remove rpc directory * final fix Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11830
polkadot companion: paritytech/polkadot#5784
Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA
Update
This new runtime api call can be used by wallets to receive the pending rewards of a specific member.
The total pending rewards of a pool is basically the balance of the reward account, minus existential deposit.