This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix nomination pools pending rewards RPC#12095
Merged
paritytech-processbot[bot] merged 5 commits intomasterfrom Aug 28, 2022
Merged
Fix nomination pools pending rewards RPC#12095paritytech-processbot[bot] merged 5 commits intomasterfrom
paritytech-processbot[bot] merged 5 commits intomasterfrom
Conversation
kianenigma
added
A0-please_review
github-actions
bot
added
A3-in_progress
Contributor
Author
|
cc @Szegoo lesson learned the hard way, my suggestion about how to do this in the original PR was wrong, and I didn't ask for a test. |
kianenigma
added
B7-runtimenoteworthy
and removed
B0-silent
rossbulat
approved these changes
Aug 23, 2022
rossbulat
left a comment
rossbulat
left a comment
There was a problem hiding this comment.
The test looks good, payouts are distributed proportionally to the join bond of each member at the correct stages.
None is yielded when member is not a member of the pool.
ggwpez
approved these changes
Aug 24, 2022
Contributor
I believe that is because this isn't actually a custom RPC, you should be able to use |
bkchr
approved these changes
Aug 27, 2022
bkchr
reviewed
Aug 27, 2022
Contributor
Author
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#5924 |
shawntabrizi
approved these changes
Aug 28, 2022
kianenigma
commented
Aug 28, 2022
shawntabrizi
approved these changes
Aug 28, 2022
Contributor
Author
|
bot merge |
2 tasks
7 tasks
vimukthi-git
pushed a commit
to ComposableFi/composable
that referenced
this pull request
Jan 18, 2023
#### Intro Upgrade polkadot from v0.9.27 to v0.9.30 as a checkpoint, then to v0.9.33 (latest version without workspace dependencies) Require ComposableFi/composable-ibc#176 to be merged first. #### Migrations - v0.9.28 - [x] paritytech/polkadot#5582 - Nomination not present in our runtimes - v0.9.29 - [x] paritytech/substrate#12095 - Nomination not present in our runtimes - v0.9.30 - [x] paritytech/substrate#12034 - BagList/Staking not present in our runtimes - [x] paritytech/polkadot#5930 - Nomination/BagList/Staking not present in our runtimes - [x] paritytech/substrate#12230 - Staking not present in our runtimes - [x] paritytech/polkadot#5996 - Staking not present in our runtimes - [x] paritytech/substrate#12083 - Contracts not present in our runtimes Signed-off-by: cor <cor@pruijs.dev> Co-authored-by: cor <cor@pruijs.dev>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Fix nomination pools pending rewards RPC * Fix node * Update frame/nomination-pools/src/lib.rs * Fix docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the RPC added in #11831 had a small bug. This fixes it.
Polkadot companion: paritytech/polkadot#5924