Maximum value for `MultiplierUpdate` by Szegoo · Pull Request #12282 · paritytech/substrate

Szegoo · 2022-09-15T15:58:53Z

Fixes #12240

polkadot companion: paritytech/polkadot#6021

Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA

frame/transaction-payment/src/lib.rs

Co-authored-by: Stephen Shelton <steve@brewcraft.org>

kianenigma · 2022-09-20T13:09:00Z

@Szegoo would be good if you link to the issue properly https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Szegoo · 2022-09-20T13:12:19Z

@Szegoo would be good if you link to the issue properly https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Just noticed, sorry for this.

frame/transaction-payment/src/lib.rs

kianenigma

LGTM once my comments are resolved. As usual, please add your polkadot address as well.

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Szegoo · 2022-09-21T18:05:09Z

I have resolved the comments.

I have added my polkadot address, thanks :)

notlesh · 2022-09-30T15:52:50Z

This PR is useful for Moonbeam, we'd love to see it get merged soon :)

kianenigma · 2022-10-03T07:39:51Z

/tip small

substrate-tip-bot · 2022-10-03T07:39:54Z

@kianenigma A small tip was successfully submitted for Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

frame/transaction-payment/src/lib.rs

KiChjang

Looks good after addressing my comment.

frame/transaction-payment/src/lib.rs

bin/node-template/runtime/src/lib.rs

frame/transaction-payment/src/lib.rs

kianenigma · 2022-10-06T12:12:42Z

bot merge

* Maximum value for MultiplierUpdate * Update frame/transaction-payment/src/lib.rs Co-authored-by: Stephen Shelton <steve@brewcraft.org> * Update lib.rs * return constant * fix in runtime * Update frame/transaction-payment/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/transaction-payment/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * fixes * remove unused import * Update lib.rs * more readable * fix * fix nits Co-authored-by: Stephen Shelton <steve@brewcraft.org> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Maximum value for MultiplierUpdate

e131849

Szegoo changed the title ~~Maximum value for MultiplierUpdate~~ Maximum value for MultiplierUpdate Sep 15, 2022

Szegoo commented Sep 15, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

notlesh reviewed Sep 15, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

notlesh reviewed Sep 15, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

Szegoo and others added 4 commits September 15, 2022 21:09

Update frame/transaction-payment/src/lib.rs

16d81fa

Co-authored-by: Stephen Shelton <steve@brewcraft.org>

Update lib.rs

833ff88

return constant

308a786

fix in runtime

d1eee7f

Szegoo mentioned this pull request Sep 16, 2022

Maximum value for MultiplierUpdate paritytech/polkadot#6021

Merged

Szegoo added 3 commits September 16, 2022 15:09

Merge branch 'paritytech:master' into transaction-payment-multiplier

f125178

Merge branch 'paritytech:master' into transaction-payment-multiplier

653bc49

Merge branch 'paritytech:master' into transaction-payment-multiplier

21f0118

ggwpez mentioned this pull request Sep 18, 2022

updated MultiplierUpdate trait #12288

Closed

kianenigma self-requested a review September 20, 2022 13:07

kianenigma added the A0-please_review Pull request needs code review. label Sep 20, 2022

kianenigma reviewed Sep 21, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Sep 21, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Sep 21, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

kianenigma approved these changes Sep 21, 2022

View reviewed changes

Szegoo and others added 5 commits September 21, 2022 19:40

Update frame/transaction-payment/src/lib.rs

c58bd09

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Update frame/transaction-payment/src/lib.rs

717cb7e

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

fixes

b6b6e4a

Merge branch 'paritytech:master' into transaction-payment-multiplier

8be1be3

remove unused import

db5cdef

kianenigma requested review from bkchr and ggwpez September 24, 2022 08:25

kianenigma added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 24, 2022

KiChjang reviewed Oct 6, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

Update lib.rs

b630fb1

KiChjang reviewed Oct 6, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

KiChjang approved these changes Oct 6, 2022

View reviewed changes

more readable

e651e54

KiChjang reviewed Oct 6, 2022

View reviewed changes

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

fix

39ba563

ggwpez reviewed Oct 6, 2022

View reviewed changes

bin/node-template/runtime/src/lib.rs Outdated Show resolved Hide resolved

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

frame/transaction-payment/src/lib.rs Show resolved Hide resolved

Szegoo and others added 2 commits October 6, 2022 11:37

fix nits

3517f13

Merge branch 'paritytech:master' into transaction-payment-multiplier

0b4ed8d

ggwpez approved these changes Oct 6, 2022

View reviewed changes

paritytech-processbot bot merged commit a84def9 into paritytech:master Oct 6, 2022

notlesh mentioned this pull request Oct 6, 2022

Adds MaximumMultiplier as upper bound for dynamic fee multiplier moonbeam-foundation/moonbeam#1853

Merged

Szegoo mentioned this pull request Oct 7, 2022

Member Request polkadot-fellows/seeding#36

Merged

Dengjianping mentioned this pull request Oct 11, 2022

Consider to give a proper value for MultiplierUpdate Manta-Network/Manta#832

Open

chevdor mentioned this pull request Oct 24, 2022

Fix clippy for Cumulus 0.9.30 #12556

Closed

github-actions bot mentioned this pull request Nov 10, 2022

Update substrate/polkadot/cumulus from v0.9.29 to v0.9.31 moonbeam-foundation/moonbeam#1942

Closed

github-actions bot mentioned this pull request Nov 23, 2022

Update substrate/polkadot/cumulus from v0.9.29 to v0.9.32 moonbeam-foundation/moonbeam#1965

Closed

aurexav mentioned this pull request Jan 10, 2023

To polkadot-v0.9.33 darwinia-network/darwinia-2.0#194

Closed

Conversation

Szegoo commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma commented Sep 20, 2022

Uh oh!

Szegoo commented Sep 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Szegoo commented Sep 21, 2022

Uh oh!

notlesh commented Sep 30, 2022

Uh oh!

kianenigma commented Oct 3, 2022

Uh oh!

substrate-tip-bot bot commented Oct 3, 2022

Uh oh!

Uh oh!

Uh oh!

KiChjang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma commented Oct 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Szegoo commented Sep 15, 2022 •

edited

Loading

kianenigma left a comment •

edited

Loading