This repository was archived by the owner on Nov 15, 2023. It is now read-only.
updated MultiplierUpdate trait#12288
Closed
MrishoLukamba wants to merge 1 commit intoparitytech:masterfrom
MrishoLukamba:mhl-MultplierTrait
Closed
updated MultiplierUpdate trait#12288MrishoLukamba wants to merge 1 commit intoparitytech:masterfrom MrishoLukamba:mhl-MultplierTrait
MrishoLukamba wants to merge 1 commit intoparitytech:masterfrom
MrishoLukamba:mhl-MultplierTrait
Conversation
Member
|
Duplicate of #12282 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #12240,
Concerning enforcing the returned Multiplier should be less than Next block fees multiplier , I have put that if the returned multiplier is greater than maximum multiplier then return the maximum multiplier.
I have set maximum multiplier to be Bounded::max_value.
Please instruct me If i can improve the above the logic.
@kianenigma