Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Deprecate decl_* macros#12326

Closed
koushiro wants to merge 4 commits intoparitytech:masterfrom
koushiro:deprecate-old-decl-macros
Closed

Deprecate decl_* macros#12326
koushiro wants to merge 4 commits intoparitytech:masterfrom
koushiro:deprecate-old-decl-macros

Conversation

@koushiro
Copy link
Contributor

@koushiro koushiro commented Sep 22, 2022

Close #12248

@koushiro
Deprecate decl_* macros
a5dbf53 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Fix decl_module_ui and decl_storage_ui tests
666ed85 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Copy link
Contributor Author

koushiro commented Sep 22, 2022

@bkchr @KiChjang @kianenigma PTAL

bkchr
bkchr reviewed Sep 22, 2022
View reviewed changes
@koushiro
Apply review suggestions
acd0b29 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
KiChjang
KiChjang reviewed Sep 23, 2022
View reviewed changes
KiChjang
KiChjang reviewed Sep 23, 2022
View reviewed changes
@KiChjang
Copy link
Contributor

KiChjang commented Sep 23, 2022

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

@KiChjang KiChjang mentioned this pull request Sep 23, 2022
Merged
@koushiro
Copy link
Contributor Author

koushiro commented Sep 23, 2022 •
edited
Loading

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

I have no particular preference for deleting or deprecating decl_* macros, and both are fine for me.

But I don't know what other people think, whether the macros need to deprecated firstly, and then remove it in a later version ?

@koushiro
Update deprecate note of decl_module
f0b6eed 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@bkchr
Copy link
Member

bkchr commented Sep 23, 2022

Actually, I don't think we should simply deprecate at this point -- we should just remove all of these decl_* macros altogether and be done with it.

We can open a forum thread in Polkadot forum and make some poll. I don't know if someone is may still using them.

@shawntabrizi
Copy link
Member

shawntabrizi commented Sep 24, 2022

Let's just remove it.

We have plenty of documentation on how to migrate, and we really should encourage people to switch over if they have not.

@koushiro
Copy link
Contributor Author

koushiro commented Sep 27, 2022

Let's just remove it.

We have plenty of documentation on how to migrate, and we really should encourage people to switch over if they have not.

Okay, I will open another PR to remove it.

@kianenigma
Copy link
Contributor

kianenigma commented Sep 30, 2022

Seems like we will see a new PR, so I will close this one. Please reopen if otherwise.

@kianenigma kianenigma closed this Sep 30, 2022
@koushiro koushiro mentioned this pull request Oct 3, 2022
Merged
@koushiro koushiro deleted the deprecate-old-decl-macros branch May 9, 2023 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@KiChjang KiChjang KiChjang left review comments

@bkchr bkchr bkchr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Deprecation] Deprecate decl_* macros

5 participants

@koushiro @KiChjang @bkchr @shawntabrizi @kianenigma