This repository was archived by the owner on Nov 15, 2023. It is now read-only.
frame-support: migrate some tests from decl_* macros to the new pallet macros#12401
Merged
paritytech-processbot[bot] merged 12 commits intoparitytech:masterfrom Apr 25, 2023
koushiro:remove-decl-macros-part1
Merged
frame-support: migrate some tests from decl_* macros to the new pallet macros#12401paritytech-processbot[bot] merged 12 commits intoparitytech:masterfrom koushiro:remove-decl-macros-part1
decl_* macros to the new pallet macros#12401paritytech-processbot[bot] merged 12 commits intoparitytech:masterfrom
koushiro:remove-decl-macros-part1
Conversation
Contributor
Author
koushiro
changed the title
decl_* macros to the new pallet macros
KiChjang
reviewed
Oct 3, 2022
KiChjang
reviewed
Oct 3, 2022
Contributor
Author
|
Is there anyone else who can review this PR? |
kianenigma
reviewed
Oct 25, 2022
kianenigma
approved these changes
Nov 17, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Looks broadly good, just a bit confused about naming details.
…part1 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A3-in_progress
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
reviewed
Apr 12, 2023
ggwpez
added
A0-please_review
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
reviewed
Apr 17, 2023
Member
|
bot rebase |
|
Rebased |
ggwpez
approved these changes
Apr 25, 2023
Member
|
bot merge |
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
…llet` macros (#12401) * frame-support: migrate some tests from decl macros to new pallet attribute macros * Remove useless type alias * Remove useless type alias * Work around for rust issue 52234 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use polkadot-compatible paste version Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix crate access and add tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Typo Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…llet` macros (paritytech#12401) * frame-support: migrate some tests from decl macros to new pallet attribute macros * Remove useless type alias * Remove useless type alias * Work around for rust issue 52234 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use polkadot-compatible paste version Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix crate access and add tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Typo Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: parity-processbot <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR is a part of #12248.
After some discussion in #12326, most developers prefer to just remove the old
decl_*macros.But there is a lot of code changes involved, so I split it into multiple smaller PRs to be reviewed and merged as quickly as possible into the master branch.
In this PR, I migrate the some tests of
frame-supportfrom olddecl_*macros to the new pallet attribute macros.After this, I will migrate the
frame-support-testfromdecl_*macros to pallet macros and finally remove thedecl_*macros and do some other trivial things.