add warp to target block for parachains by samelamin · Pull Request #12761 · paritytech/substrate

samelamin · 2022-11-22T18:05:40Z

This PR is the first part of a 3 part PR to Substrate,Polkadot and Cumulus to address paritytech/cumulus#1619

The goal of the PR is to enable warp sync support for parachains and is done by passing an enum WarpSyncParams that lets ChainSync start the warp sync to a target block

polkadot companion: paritytech/polkadot#6334
cumulus companion: paritytech/cumulus#1909

polkadot address: 13xS6fK6MHjApLnjdX7TJYw1niZmiXasSN91bNtiXQjgEtNx

samelamin · 2022-11-23T10:45:14Z

I think the failure continuous-integration/gitlab-check-dependent-polkadot is due to the fact that we need to do a PR into both Polkadot and Cumulus to apply the new changes.

How are these interdependencies managed? I am assuming PRs need to go into substrate first before making the changes downstream?

altonen · 2022-11-23T10:55:41Z

You need to add a polkadot companion: https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#updating-polkadot-as-well

samelamin · 2022-11-23T11:02:22Z

You need to add a polkadot companion: https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#updating-polkadot-as-well

Awesome, thanks @altonen ill make the changes required. Since I don't have rights to rerun the job ill just push a new commit to start the CI jobs.

samelamin · 2022-11-23T14:14:32Z

Failing builds are meant to be fixed by this pr

paritytech/scripts#488

client/network/sync/src/lib.rs

samelamin · 2022-12-06T16:26:16Z

Hi Everyone, let me know if there are any more changes that are required on this pr

client/network/test/src/sync.rs

client/network/sync/src/warp.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

… when an error occurs

bkchr · 2023-02-14T16:09:54Z

bot merge

paritytech-processbot · 2023-02-14T16:10:10Z

Error: "Check reviews" status is not passing for paritytech/polkadot#6334

bkchr · 2023-02-14T17:45:07Z

bot merge

paritytech-processbot · 2023-02-14T17:45:16Z

Error: "Check reviews" status is not passing for paritytech/cumulus#1909

bkchr · 2023-02-14T17:46:41Z

bot merge

bkchr · 2023-02-14T18:42:49Z

/tip big

substrate-tip-bot · 2023-02-14T18:42:52Z

@bkchr ERROR: Error: Invalid tip size. Please specify one of small, medium, large.
Error: Invalid tip size. Please specify one of small, medium, large.
at getTipSize (/usr/src/app/dist/tip.js:1:559)
at onIssueComment (/usr/src/app/dist/bot.js:1:1171)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)

bkchr · 2023-02-14T18:42:58Z

/tip large

substrate-tip-bot · 2023-02-14T18:43:01Z

@bkchr A large tip was successfully submitted for samelamin (13xS6fK6MHjApLnjdX7TJYw1niZmiXasSN91bNtiXQjgEtNx on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

Polkadot-Forum · 2023-03-09T19:30:24Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-39/2277/1

samelamin marked this pull request as draft November 22, 2022 19:44

samelamin marked this pull request as ready for review November 23, 2022 09:57

samelamin force-pushed the warp_sync_parachain branch 3 times, most recently from d01a812 to 35d282c Compare November 23, 2022 10:23

samelamin marked this pull request as draft November 23, 2022 11:02

samelamin force-pushed the warp_sync_parachain branch from 35d282c to 085ac43 Compare November 23, 2022 13:33

samelamin marked this pull request as ready for review November 23, 2022 13:33

samelamin force-pushed the warp_sync_parachain branch from 085ac43 to 99eda33 Compare November 23, 2022 14:02

samelamin force-pushed the warp_sync_parachain branch 5 times, most recently from 56937ac to 365149f Compare November 24, 2022 10:56

This was referenced Nov 24, 2022

add warp_sync_params paritytech/cumulus#1909

Merged

add warp sync params to enable parachain warp sync paritytech/polkadot#6334

Merged

samelamin force-pushed the warp_sync_parachain branch 4 times, most recently from 98aa2cc to e9548f9 Compare November 25, 2022 15:44

bkchr reviewed Nov 25, 2022

View reviewed changes

client/network/sync/src/lib.rs Outdated Show resolved Hide resolved

samelamin force-pushed the warp_sync_parachain branch 3 times, most recently from 1b74892 to 0c67920 Compare November 28, 2022 14:58

samelamin requested a review from bkchr December 5, 2022 13:17

samelamin and others added 3 commits February 13, 2023 15:10

bump zombienet again

be94536

Merge branch 'master' into warp_sync_parachain

d973272

Improve test

de75501

bkchr approved these changes Feb 14, 2023

View reviewed changes

client/network/test/src/sync.rs Outdated Show resolved Hide resolved

client/network/test/src/sync.rs Outdated Show resolved Hide resolved

client/network/sync/src/warp.rs Show resolved Hide resolved

samelamin and others added 6 commits February 14, 2023 09:04

Update client/network/test/src/sync.rs

501c4f4

Co-authored-by: Bastian Köcher <git@kchr.de>

Update client/network/test/src/sync.rs

4cc074e

Co-authored-by: Bastian Köcher <git@kchr.de>

fix tests

03a3b72

dummy commit to restart builds

3d8ecac

Converted the target block to an optional value that is set to None…

f12c16a

… when an error occurs

dummy commit to restart builds

10e248f

bkchr approved these changes Feb 14, 2023

View reviewed changes

samelamin mentioned this pull request Feb 14, 2023

Membership Request polkadot-fellows/seeding#40

Closed

JoshOrndorff mentioned this pull request Mar 1, 2023

Update Substrate to monthly-2023-03 Off-Narrative-Labs/Tuxedo#9

Merged

kamilsa mentioned this pull request Mar 23, 2023

Add warp sync with parameters for parachains qdrvm/kagome#1535

Closed

kiltbot mentioned this pull request Apr 3, 2023

[AUTOMATIC] Update Polkadot dependencies from 0.9.38 to 0.9.39 KILTprotocol/kilt-node#495

Closed

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

Dinonard mentioned this pull request Apr 7, 2023

Enable warp sync AstarNetwork/Astar#901

Merged

5 tasks

arkpar mentioned this pull request Apr 14, 2023

warp_sync hanging on AwaitPeers if warp_sync_params is None paritytech/polkadot-sdk#14

Closed

2 tasks

b-yap mentioned this pull request May 25, 2023

upgrade to polkadot-v0.9.40 pendulum-chain/spacewalk#350

Merged

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

Conversation

samelamin commented Nov 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samelamin commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

altonen commented Nov 23, 2022

Uh oh!

samelamin commented Nov 23, 2022

Uh oh!

samelamin commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

samelamin commented Dec 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkchr commented Feb 14, 2023

Uh oh!

paritytech-processbot bot commented Feb 14, 2023

Uh oh!

bkchr commented Feb 14, 2023

Uh oh!

paritytech-processbot bot commented Feb 14, 2023

Uh oh!

bkchr commented Feb 14, 2023

Uh oh!

bkchr commented Feb 14, 2023

Uh oh!

substrate-tip-bot bot commented Feb 14, 2023

Uh oh!

bkchr commented Feb 14, 2023

Uh oh!

substrate-tip-bot bot commented Feb 14, 2023

Uh oh!

Polkadot-Forum commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

samelamin commented Nov 22, 2022 •

edited

Loading

samelamin commented Nov 23, 2022 •

edited

Loading

samelamin commented Nov 23, 2022 •

edited

Loading