Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Account touch trait#14063

Merged
joepetrowski merged 10 commits intojoe-asset-freezecreatingfrom
muharem-asset-touch-trait
May 4, 2023
Merged

Account touch trait#14063
joepetrowski merged 10 commits intojoe-asset-freezecreatingfrom
muharem-asset-touch-trait

Conversation

@muharem
Copy link
Contributor

@muharem muharem commented May 2, 2023 •
edited
Loading

This PR introduces AccountTouch trait and its implementation by pallet-assets which allows the creation of asset account for some account id with a designated depositor.

requires #13843

kianenigma
kianenigma reviewed May 3, 2023
View reviewed changes
kianenigma
kianenigma reviewed May 3, 2023
View reviewed changes
kianenigma
kianenigma reviewed May 3, 2023
View reviewed changes
kianenigma
kianenigma reviewed May 3, 2023
View reviewed changes
muharem and others added 2 commits May 3, 2023 17:49
@muharem @kianenigma
Apply suggestions from code review
da697b2 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@muharem
move trait to misc, drop option
ab596c7
@muharem muharem changed the title Assets touch trait Account touch trait May 3, 2023
@muharem muharem added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited T1-runtime This PR/Issue is related to the topic “runtime”. labels May 3, 2023
gavofyork
gavofyork reviewed May 4, 2023
View reviewed changes
gavofyork
gavofyork reviewed May 4, 2023
View reviewed changes
gavofyork
gavofyork reviewed May 4, 2023
View reviewed changes
gavofyork
gavofyork reviewed May 4, 2023
View reviewed changes
gavofyork
gavofyork reviewed May 4, 2023
View reviewed changes
Copy link
Member

@gavofyork gavofyork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quibbles over docs and naming, but seems harmless otherwise

muharem and others added 2 commits May 4, 2023 11:19
@muharem @gavofyork
Apply suggestions from code review
4fcc918 
Co-authored-by: Gavin Wood <gavin@parity.io>
@muharem
correct doc
df1f4b8
@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented May 4, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2777941

@muharem muharem added the A0-please_review Pull request needs code review. label May 4, 2023
@muharem muharem marked this pull request as ready for review May 4, 2023 09:41
@louismerlin louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels May 4, 2023
joepetrowski
joepetrowski approved these changes May 4, 2023
View reviewed changes
@joepetrowski joepetrowski merged commit 239af28 into joe-asset-freezecreating May 4, 2023
@joepetrowski joepetrowski deleted the muharem-asset-touch-trait branch May 4, 2023 13:06
jsidorenko
jsidorenko reviewed May 4, 2023
View reviewed changes
paritytech-processbot bot pushed a commit that referenced this pull request May 8, 2023
@joepetrowski @muharem
@kianenigma @gavofyork @jsidorenko
Allow Creation of Asset Accounts That Don't Exist Yet and Add `Blocke…
cf1fb89 
…d` Status (#13843)

* prevent frozen accounts from receiving assets

* refund deposits correctly

* plus refund_other

* add benchmarks

* start migration work

* docs

* add migration logic

* fix freeze_creating benchmark

* support instanced migrations

* review

* correct deposit refund

* only allow depositor, admin, or account origin to refund deposits

* make sure refund actually removes account

* do refund changes

* Asset's account deposit owner (#13874)

* assets deposit owner

* doc typo

* remove migration

* empty commit

* can transfer to frozen account

* remove allow_burn from refund_other

* storage version back to 1

* update doc

* fix benches

* update docs

* more tests

* Update frame/assets/src/types.rs

* refund updating the reason

* refactor

* separate refund and refund_foreign

* refunds, touch_other, tests

* fixes

* fmt

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets

* tests: asserts asset account counts

* Account touch trait (#14063)

* assets touch trait

* docs

* move touch trait into support/traits

* permissionless flag for do_touch

* Apply suggestions from code review

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* move trait to misc, drop option

* Apply suggestions from code review

Co-authored-by: Gavin Wood <gavin@parity.io>

* correct doc

* Update frame/assets/src/functions.rs

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* Block asset account (#14070)

* replace is_fronzen flag by status enum

* block asset account

* remove redundant brackets

* fix typo

* fmt

* Apply suggestions from code review

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

* rename permissionless to check_depositor

* doc fix

* use account id lookup instead account id

* add benchmark for touch_other

---------

Co-authored-by: muharem <ismailov.m.h@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
EgorPopelyaev pushed a commit that referenced this pull request May 11, 2023
@joepetrowski @muharem
@kianenigma @gavofyork @jsidorenko @EgorPopelyaev
Allow Creation of Asset Accounts That Don't Exist Yet and Add `Blocke…
d315f41 
…d` Status (#13843)

* prevent frozen accounts from receiving assets

* refund deposits correctly

* plus refund_other

* add benchmarks

* start migration work

* docs

* add migration logic

* fix freeze_creating benchmark

* support instanced migrations

* review

* correct deposit refund

* only allow depositor, admin, or account origin to refund deposits

* make sure refund actually removes account

* do refund changes

* Asset's account deposit owner (#13874)

* assets deposit owner

* doc typo

* remove migration

* empty commit

* can transfer to frozen account

* remove allow_burn from refund_other

* storage version back to 1

* update doc

* fix benches

* update docs

* more tests

* Update frame/assets/src/types.rs

* refund updating the reason

* refactor

* separate refund and refund_foreign

* refunds, touch_other, tests

* fixes

* fmt

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets

* tests: asserts asset account counts

* Account touch trait (#14063)

* assets touch trait

* docs

* move touch trait into support/traits

* permissionless flag for do_touch

* Apply suggestions from code review

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* move trait to misc, drop option

* Apply suggestions from code review

Co-authored-by: Gavin Wood <gavin@parity.io>

* correct doc

* Update frame/assets/src/functions.rs

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* Block asset account (#14070)

* replace is_fronzen flag by status enum

* block asset account

* remove redundant brackets

* fix typo

* fmt

* Apply suggestions from code review

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

* rename permissionless to check_depositor

* doc fix

* use account id lookup instead account id

* add benchmark for touch_other

---------

Co-authored-by: muharem <ismailov.m.h@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@joepetrowski @muharem
@kianenigma @gavofyork @jsidorenko @nathanwhit
Allow Creation of Asset Accounts That Don't Exist Yet and Add `Blocke…
37f251c 
…d` Status (paritytech#13843)

* prevent frozen accounts from receiving assets

* refund deposits correctly

* plus refund_other

* add benchmarks

* start migration work

* docs

* add migration logic

* fix freeze_creating benchmark

* support instanced migrations

* review

* correct deposit refund

* only allow depositor, admin, or account origin to refund deposits

* make sure refund actually removes account

* do refund changes

* Asset's account deposit owner (paritytech#13874)

* assets deposit owner

* doc typo

* remove migration

* empty commit

* can transfer to frozen account

* remove allow_burn from refund_other

* storage version back to 1

* update doc

* fix benches

* update docs

* more tests

* Update frame/assets/src/types.rs

* refund updating the reason

* refactor

* separate refund and refund_foreign

* refunds, touch_other, tests

* fixes

* fmt

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets

* tests: asserts asset account counts

* Account touch trait (paritytech#14063)

* assets touch trait

* docs

* move touch trait into support/traits

* permissionless flag for do_touch

* Apply suggestions from code review

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* move trait to misc, drop option

* Apply suggestions from code review

Co-authored-by: Gavin Wood <gavin@parity.io>

* correct doc

* Update frame/assets/src/functions.rs

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* Block asset account (paritytech#14070)

* replace is_fronzen flag by status enum

* block asset account

* remove redundant brackets

* fix typo

* fmt

* Apply suggestions from code review

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

* rename permissionless to check_depositor

* doc fix

* use account id lookup instead account id

* add benchmark for touch_other

---------

Co-authored-by: muharem <ismailov.m.h@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@gavofyork gavofyork gavofyork left review comments

@jsidorenko jsidorenko jsidorenko left review comments

@kianenigma kianenigma kianenigma left review comments

@joepetrowski joepetrowski joepetrowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@muharem @paritytech-cicd-pr @gavofyork @jsidorenko @kianenigma @joepetrowski @louismerlin