Allow Creation of Asset Accounts That Don't Exist Yet and Add `Blocked` Status by joepetrowski · Pull Request #13843 · paritytech/substrate

joepetrowski · 2023-04-06T12:43:03Z

Adds new dispatchables touch_other and refund_other, allowing an asset class's Freezer or Admin to create an account with zero balance in the asset class by placing a deposit; and to remove/refund. The existence of the account is represented by a new ExistenceReason::DepositFrom variant.
Adds a new trait AccountTouch that allows other pallets to touch an account into existence for an asset class.
Adds a new account status of Blocked (invoked by the asset class's Freezer via the new dispatchable block). Unlike Frozen, which prevents withdrawals from an account, Blocked prevents both withdrawals from and deposits into the blocked account. The account can be returned to its unrestricted (Liquid) state via the existing thaw function.

Cumulus Companion: paritytech/cumulus#2437

Made in collaborating with @muharem

frame/assets/src/types.rs

frame/assets/src/lib.rs

frame/assets/src/functions.rs

joepetrowski · 2023-04-09T05:59:30Z

I am missing a test to check that an account does not get reaped in case reason matches ExistenceReason::DepositHeld(_) for refund() and refund_other()

Good call, if someone places a deposit, someone else shouldn't be able to remove that account. Updated logic / test.

frame/assets/src/functions.rs

jsidorenko

Unblocking, as it turned out, the migration is not needed since the encoded value stays the same despite the AssetAccount.status field had got changed

joepetrowski · 2023-05-07T05:42:26Z

bot rebase

…ating

paritytech-processbot · 2023-05-07T05:42:35Z

Rebased

joepetrowski · 2023-05-08T09:24:50Z

bot merge

paritytech-processbot · 2023-05-08T09:24:58Z

Error: Github API says paritytech/cumulus#2437 is not mergeable

muharem · 2023-05-08T09:32:06Z

bot rebase

…ating

paritytech-processbot · 2023-05-08T09:32:12Z

Rebased

muharem · 2023-05-08T10:17:27Z

bot merge

…d` Status (#13843) * prevent frozen accounts from receiving assets * refund deposits correctly * plus refund_other * add benchmarks * start migration work * docs * add migration logic * fix freeze_creating benchmark * support instanced migrations * review * correct deposit refund * only allow depositor, admin, or account origin to refund deposits * make sure refund actually removes account * do refund changes * Asset's account deposit owner (#13874) * assets deposit owner * doc typo * remove migration * empty commit * can transfer to frozen account * remove allow_burn from refund_other * storage version back to 1 * update doc * fix benches * update docs * more tests * Update frame/assets/src/types.rs * refund updating the reason * refactor * separate refund and refund_foreign * refunds, touch_other, tests * fixes * fmt * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets * tests: asserts asset account counts * Account touch trait (#14063) * assets touch trait * docs * move touch trait into support/traits * permissionless flag for do_touch * Apply suggestions from code review Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * move trait to misc, drop option * Apply suggestions from code review Co-authored-by: Gavin Wood <gavin@parity.io> * correct doc * Update frame/assets/src/functions.rs --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Block asset account (#14070) * replace is_fronzen flag by status enum * block asset account * remove redundant brackets * fix typo * fmt * Apply suggestions from code review Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> * rename permissionless to check_depositor * doc fix * use account id lookup instead account id * add benchmark for touch_other --------- Co-authored-by: muharem <ismailov.m.h@gmail.com> Co-authored-by: command-bot <> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

gilescope · 2023-05-12T18:08:24Z

What happens if a local asset's deposit is different to a foreign asset? Doesn't AccountTouch::deposit_required() need to take an AssetId to be able to answer that question?

gavofyork · 2023-05-15T13:47:55Z

Seems a reasonable point; @muharem ^^^?

muharem · 2023-05-15T14:35:12Z

What happens if a local asset's deposit is different to a foreign asset? Doesn't AccountTouch::deposit_required() need to take an AssetId to be able to answer that question?

#14147

…d` Status (paritytech#13843) * prevent frozen accounts from receiving assets * refund deposits correctly * plus refund_other * add benchmarks * start migration work * docs * add migration logic * fix freeze_creating benchmark * support instanced migrations * review * correct deposit refund * only allow depositor, admin, or account origin to refund deposits * make sure refund actually removes account * do refund changes * Asset's account deposit owner (paritytech#13874) * assets deposit owner * doc typo * remove migration * empty commit * can transfer to frozen account * remove allow_burn from refund_other * storage version back to 1 * update doc * fix benches * update docs * more tests * Update frame/assets/src/types.rs * refund updating the reason * refactor * separate refund and refund_foreign * refunds, touch_other, tests * fixes * fmt * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets * tests: asserts asset account counts * Account touch trait (paritytech#14063) * assets touch trait * docs * move touch trait into support/traits * permissionless flag for do_touch * Apply suggestions from code review Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * move trait to misc, drop option * Apply suggestions from code review Co-authored-by: Gavin Wood <gavin@parity.io> * correct doc * Update frame/assets/src/functions.rs --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Block asset account (paritytech#14070) * replace is_fronzen flag by status enum * block asset account * remove redundant brackets * fix typo * fmt * Apply suggestions from code review Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> * rename permissionless to check_depositor * doc fix * use account id lookup instead account id * add benchmark for touch_other --------- Co-authored-by: muharem <ismailov.m.h@gmail.com> Co-authored-by: command-bot <> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

joepetrowski added 7 commits April 4, 2023 14:40

prevent frozen accounts from receiving assets

b71655a

Merge remote-tracking branch 'origin' into joe-asset-freezecreating

cea71eb

refund deposits correctly

97faa51

plus refund_other

16f6980

add benchmarks

eaaa623

start migration work

d64fc90

docs

80eac19

joepetrowski commented Apr 6, 2023

View reviewed changes

frame/assets/src/types.rs Outdated Show resolved Hide resolved

joepetrowski added the T1-runtime This PR/Issue is related to the topic “runtime”. label Apr 6, 2023

add migration logic

d3c51df

joepetrowski mentioned this pull request Apr 6, 2023

Substrate 13843 (Asset Freezing) Companion paritytech/cumulus#2437

Merged

joepetrowski requested review from NachoPal, muharem and tonyalaribe April 6, 2023 19:09

joepetrowski added 3 commits April 6, 2023 21:26

Merge remote-tracking branch 'origin' into joe-asset-freezecreating

5bcd359

fix freeze_creating benchmark

67c04cc

support instanced migrations

489dea5

muharem reviewed Apr 7, 2023

View reviewed changes

frame/assets/src/lib.rs Show resolved Hide resolved

frame/assets/src/functions.rs Outdated Show resolved Hide resolved

frame/assets/src/functions.rs Outdated Show resolved Hide resolved

frame/assets/src/functions.rs Outdated Show resolved Hide resolved

joepetrowski added 2 commits April 7, 2023 14:20

review

6fc0ff0

correct deposit refund

8fe2e45

This comment was marked as resolved.

Sign in to view

only allow depositor, admin, or account origin to refund deposits

c5ece2f

NachoPal reviewed Apr 10, 2023

View reviewed changes

frame/assets/src/functions.rs Outdated Show resolved Hide resolved

NachoPal reviewed Apr 10, 2023

View reviewed changes

frame/assets/src/functions.rs Outdated Show resolved Hide resolved

make sure refund actually removes account

7634da2

jsidorenko approved these changes May 4, 2023

View reviewed changes

muharem and others added 4 commits May 4, 2023 17:16

rename permissionless to check_depositor

6919695

doc fix

c8f5df2

use account id lookup instead account id

cca3f57

add benchmark for touch_other

1faf270

Merge remote-tracking branch 'origin/master' into joe-asset-freezecre…

57e8719

…ating

paritytech-processbot bot requested a review from a team May 7, 2023 05:42

joepetrowski changed the title ~~Allow Freezing (and Creation) of Asset Accounts That Don't Exist Yet~~ Allow Creation of Asset Accounts That Don't Exist Yet and Add Blocked Status May 8, 2023

Merge remote-tracking branch 'origin/master' into joe-asset-freezecre…

97fe05b

…ating

paritytech-processbot bot merged commit cf1fb89 into master May 8, 2023

paritytech-processbot bot deleted the joe-asset-freezecreating branch May 8, 2023 10:17

louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 6, 2023

github-actions bot mentioned this pull request Jun 15, 2023

Update substrate/polkadot/cumulus from v0.9.40 to v0.9.43 moonbeam-foundation/moonbeam#2354

Closed

kiltbot mentioned this pull request Jun 21, 2023

1️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.42 to 0.9.43 KILTprotocol/kilt-node#531

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

aurexav added a commit to darwinia-network/darwinia that referenced this pull request Jul 11, 2023

Companion of paritytech/substrate#13843

4c84c5e

dmitrylavrenov mentioned this pull request Oct 29, 2024

Tracking issue to bump substrate related deps to polkadot-v0.9.43 humanode-network/humanode#923

Closed

2 tasks

Conversation

joepetrowski commented Apr 6, 2023 • edited by muharem Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

joepetrowski commented Apr 9, 2023

Uh oh!

Uh oh!

Uh oh!

jsidorenko left a comment

Choose a reason for hiding this comment

Uh oh!

joepetrowski commented May 7, 2023

Uh oh!

paritytech-processbot bot commented May 7, 2023

Uh oh!

joepetrowski commented May 8, 2023

Uh oh!

paritytech-processbot bot commented May 8, 2023

Uh oh!

muharem commented May 8, 2023

Uh oh!

paritytech-processbot bot commented May 8, 2023

Uh oh!

muharem commented May 8, 2023

Uh oh!

gilescope commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gavofyork commented May 15, 2023

Uh oh!

muharem commented May 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

joepetrowski commented Apr 6, 2023 •

edited by muharem

Loading

gilescope commented May 12, 2023 •

edited

Loading